Skip to content

Commit e102891

Browse files
test(cyclonus): [WIN-NPM] fix consistent failure from not sleeping long enough (#2174)
* test(cyclonus): [WIN-NPM] fix consistent failure from not sleeping long enough * build: fix syntax * fix: specify namespace in kubectl * fix: wait timeout=5m Signed-off-by: Hunter Gregory <[email protected]> --------- Signed-off-by: Hunter Gregory <[email protected]>
1 parent 3f313ad commit e102891

File tree

2 files changed

+6
-10
lines changed

2 files changed

+6
-10
lines changed

.pipelines/npm/npm-conformance-tests.yaml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -442,8 +442,10 @@ jobs:
442442
# swap azure-npm image with one built during run
443443
./kubectl --kubeconfig=./kubeconfig set image daemonset/azure-npm-win -n kube-system azure-npm=$IMAGE_REGISTRY/azure-npm:windows-amd64-ltsc2022-$(TAG)
444444
445-
echo "sleeping 3 minutes to allow NPM pods to restart"
446-
sleep 180
445+
echo "sleeping and waiting for NPM pods to be ready..."
446+
sleep 1m
447+
./kubectl --kubeconfig=./kubeconfig wait --for=condition=Ready pod -n kube-system -l k8s-app=azure-npm --timeout=5m
448+
echo "sleeping 3 more minutes to let windows NPM finish bootup phase"
447449
448450
./kubectl --kubeconfig=./kubeconfig get po -n kube-system -owide -A
449451

test/cyclonus/test-cyclonus-windows.sh

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,7 @@
11
LOG_FILE=cyclonus-$CLUSTER_NAME
22

3-
# curl -fsSL github.com/mattfenwick/cyclonus/releases/latest/download/cyclonus_linux_amd64.tar.gz | tar -zxv
4-
# ./cyclonus_linux_amd64/cyclonus generate \
5-
6-
# this branch has double the amount of workers
7-
git clone https://github.com/huntergregory/cyclonus.git --branch=slowness --depth=1
8-
cd cyclonus
9-
make cyclonus
10-
cmd/cyclonus/cyclonus generate \
3+
curl -fsSL github.com/mattfenwick/cyclonus/releases/latest/download/cyclonus_linux_amd64.tar.gz | tar -zxv
4+
./cyclonus_linux_amd64/cyclonus generate \
115
--noisy=true \
126
--retries=7 \
137
--ignore-loopback=true \

0 commit comments

Comments
 (0)