Skip to content

Instantiate Device Plugin #2979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 6, 2025
Merged

Instantiate Device Plugin #2979

merged 8 commits into from
Jan 6, 2025

Conversation

@aggarwal0009
Copy link
Contributor

@aggarwal0009 aggarwal0009 commented Aug 29, 2024

Reason for Change:
This PR enables device plugin

Issue Fixed:

Requirements:

Notes:

@aggarwal0009 aggarwal0009 added cns Related to CNS. swift-v2 labels Aug 29, 2024
@aggarwal0009 aggarwal0009 requested review from a team as code owners August 29, 2024 23:37
@aggarwal0009 aggarwal0009 requested a review from camrynl August 29, 2024 23:37
timraymond
timraymond requested changes Sep 3, 2024
View reviewed changes
@github-actions
Copy link

github-actions bot commented Sep 18, 2024

This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the stale Stale due to inactivity. label Sep 18, 2024
@github-actions github-actions bot removed the stale Stale due to inactivity. label Sep 20, 2024
@github-actions
Copy link

github-actions bot commented Oct 5, 2024

This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the stale Stale due to inactivity. label Oct 5, 2024
@github-actions
Copy link

github-actions bot commented Oct 13, 2024

Pull request closed due to inactivity.

@github-actions github-actions bot closed this Oct 13, 2024
@github-actions github-actions bot deleted the ankaggar/instantiate_device_plugin branch October 13, 2024 00:01
@aggarwal0009 aggarwal0009 restored the ankaggar/instantiate_device_plugin branch October 16, 2024 16:57
@aggarwal0009 aggarwal0009 reopened this Oct 16, 2024
@github-actions github-actions bot removed the stale Stale due to inactivity. label Oct 17, 2024
@timraymond
Copy link
Member

timraymond commented Nov 4, 2024

@aggarwal0009 did not see you had updated this. Please hit the re-review button in the future so I see this.

@github-actions
Copy link

github-actions bot commented Nov 21, 2024

This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the stale Stale due to inactivity. label Nov 21, 2024
@github-actions
Copy link

github-actions bot commented Nov 29, 2024

Pull request closed due to inactivity.

@github-actions github-actions bot closed this Nov 29, 2024
@github-actions github-actions bot deleted the ankaggar/instantiate_device_plugin branch November 29, 2024 00:01
@aggarwal0009 aggarwal0009 restored the ankaggar/instantiate_device_plugin branch December 13, 2024 00:54
@aggarwal0009 aggarwal0009 reopened this Dec 13, 2024
@github-actions github-actions bot removed the stale Stale due to inactivity. label Dec 14, 2024
@github-actions
Copy link

github-actions bot commented Dec 28, 2024

This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the stale Stale due to inactivity. label Dec 28, 2024
@github-actions github-actions bot removed the stale Stale due to inactivity. label Dec 31, 2024
@aggarwal0009
Copy link
Contributor Author

aggarwal0009 commented Jan 3, 2025

/azp run Azure Container Networking PR

@azure-pipelines
Copy link

azure-pipelines bot commented Jan 3, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@aggarwal0009 aggarwal0009 enabled auto-merge January 5, 2025 13:29
@aggarwal0009 aggarwal0009 added this pull request to the merge queue Jan 5, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 5, 2025
@aggarwal0009 aggarwal0009 added this pull request to the merge queue Jan 6, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 6, 2025
@aggarwal0009 aggarwal0009 added this pull request to the merge queue Jan 6, 2025
Merged via the queue into master with commit fb157cd Jan 6, 2025
14 checks passed
@aggarwal0009 aggarwal0009 deleted the ankaggar/instantiate_device_plugin branch January 6, 2025 23:52
sivakami-projects pushed a commit that referenced this pull request Oct 23, 2025
@aggarwal0009
Instantiate Device Plugin (#2979)
309d366 
* instantiate device plugin

* address pr comments

* Replace Sleep with Ticker

---------

Signed-off-by: aggarwal0009 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timraymond timraymond timraymond approved these changes

@miguelgoms miguelgoms miguelgoms approved these changes

@camrynl camrynl Awaiting requested review from camrynl camrynl is a code owner automatically assigned from Azure/acn-cns-reviewers

Assignees

No one assigned

Labels

cns Related to CNS. swift-v2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aggarwal0009 @timraymond @miguelgoms