Skip to content

Conversation

@rbtr
Copy link
Collaborator

@rbtr rbtr commented Sep 19, 2024

Reason for Change:

Updates the Go version to v1.23.1 for various improvements, fixes to stdlib, and toolchain upgrades.

Issue Fixed:

Requirements:

Notes:

@rbtr rbtr requested a review from huntergregory September 19, 2024 18:27
@rbtr rbtr enabled auto-merge September 19, 2024 18:27
@rbtr rbtr requested a review from jpayne3506 September 19, 2024 18:27
@rbtr rbtr self-assigned this Sep 19, 2024
@rbtr rbtr added cns Related to CNS. npm Related to NPM. cni Related to CNI. ci Infra or tooling. go Pull requests that update Go code release/latest Change affects latest release train needs-backport Change needs to be backported to previous release trains dropgz dropgz labels Sep 19, 2024
@rbtr
Copy link
Collaborator Author

rbtr commented Sep 19, 2024

/azp run Azure Container Networking PR

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

jpayne3506
jpayne3506 previously approved these changes Sep 19, 2024
Copy link
Contributor

@jpayne3506 jpayne3506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While it is not a priority. We may want to look at leveraging the toolchain directive to have reproduceable builds for each of our releases/tags.

@jpayne3506
Copy link
Contributor

Going to need to re-run the workflows with an updated ruleset for this to merge.

@rbtr rbtr force-pushed the chore/go1.23 branch 2 times, most recently from e0bc2e9 to d427278 Compare October 7, 2024 17:38
@rbtr rbtr force-pushed the chore/go1.23 branch 2 times, most recently from a13abcd to 07353b1 Compare October 9, 2024 16:49
@rbtr
Copy link
Collaborator Author

rbtr commented Oct 9, 2024

/azp run Azure Container Networking PR

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Evan Baker <[email protected]>
@rbtr
Copy link
Collaborator Author

rbtr commented Oct 9, 2024

/azp run Azure Container Networking PR

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

aggarwal0009
aggarwal0009 previously approved these changes Oct 9, 2024
@rbtr
Copy link
Collaborator Author

rbtr commented Oct 9, 2024

/azp run NPM Conformance Tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

paulyufan2
paulyufan2 previously approved these changes Oct 9, 2024
huntergregory
huntergregory previously approved these changes Oct 9, 2024
jpayne3506
jpayne3506 previously approved these changes Oct 9, 2024
camrynl
camrynl previously approved these changes Oct 9, 2024
@rbtr rbtr disabled auto-merge October 9, 2024 19:52
ZetaoZhuang
ZetaoZhuang previously approved these changes Oct 9, 2024
@rbtr rbtr added this pull request to the merge queue Oct 9, 2024
@rbtr rbtr removed this pull request from the merge queue due to a manual request Oct 9, 2024
@rbtr
Copy link
Collaborator Author

rbtr commented Oct 10, 2024

this passed all pipeline checks and previously had full approvals, so i'm going to merge it

@rbtr rbtr merged commit dbdb22d into master Oct 10, 2024
98 checks passed
@rbtr rbtr deleted the chore/go1.23 branch October 10, 2024 00:09
sivakami-projects pushed a commit that referenced this pull request Oct 23, 2025
* chore: update to go1.23

Signed-off-by: Evan Baker <[email protected]>

* set bpf-prog back to debian base image

Signed-off-by: Evan Baker <[email protected]>

---------

Signed-off-by: Evan Baker <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Infra or tooling. cni Related to CNI. cns Related to CNS. dropgz dropgz go Pull requests that update Go code needs-backport Change needs to be backported to previous release trains npm Related to NPM. release/latest Change affects latest release train

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants