Skip to content

Conversation

@jc2543
Copy link

@jc2543 jc2543 commented Oct 1, 2024

Reason for Change:

This PR adds the swiftv2 e2e pr checks to the Azure Container Networking PR pipeline. This is an initial PR, and needs BYOCNI enabled for swiftv2. Once we get that enabled, we will update the cluster creation script to prevent CNS/CNI images from reconciling.

Issue Fixed:

Requirements:

Notes:

@jc2543 jc2543 marked this pull request as ready for review October 1, 2024 22:15
@jc2543 jc2543 requested a review from a team as a code owner October 1, 2024 22:15
@jc2543 jc2543 requested a review from nairashu October 1, 2024 22:15
@jc2543
Copy link
Author

jc2543 commented Oct 1, 2024

/azp run Azure Container Networking PR

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@paulyufan2 paulyufan2 changed the title ci: add swiftv2 scenario to acn pr checks ci: add swiftv2 Linux scenario to acn pr checks Oct 2, 2024
dummyClusterName: "swiftv2dummy"
dummyClusterType: "swiftv2-dummy-cluster-up"
dummyClusterDisplayName: Swiftv2 Multitenancy Dummy Cluster
scenario: westcentralus
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall we pass a parameter here and in the future we can run it on other regions

region: $(region)
sub: $(SUB_AZURE_NETWORK_AGENT_TEST)
svcConn: $(ACN_TEST_SERVICE_CONNECTION)
scenario: westcentralus
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scenario is westcentralus, can you explain more about this flag meaning?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it maps to a region/scenario configuration file that we use for swiftv2 runners

sed -i '/containers:/{n;n;s/\(image\).*/\1: '"${CNS_IMAGE//\//\\/}"'/}' ./test/integration/manifests/cns/daemonset-linux.yaml
sed -i '/initContainers:/{n;n;s/\(image\).*/\1: '"${CNI_IMAGE//\//\\/}"'/}' ./test/integration/manifests/cns/daemonset-linux.yaml
sed -i '/- name: cni-installer/,/volumeMounts:/ {
/command: \["\/dropgz"\]/!b; a \ \ \ \ \ \ \ \ \ \ args:\n\ \ \ \ \ \ \ \ \ \ \ \ - deploy\n\ \ \ \ \ \ \ \ \ \ \ \ - --skip-verify\n\ \ \ \ \ \ \ \ \ \ \ \ - azure-vnet\n\ \ \ \ \ \ \ \ \ \ \ \ - -o\n\ \ \ \ \ \ \ \ \ \ \ \ - /opt/cni/bin/azure-vnet\n\ \ \ \ \ \ \ \ \ \ \ \ - azure-vnet-telemetry\n\ \ \ \ \ \ \ \ \ \ \ \ - -o\n\ \ \ \ \ \ \ \ \ \ \ \ - /opt/cni/bin/azure-vnet-telemetry
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought dropgz is deprecated already from the repo?

Copy link
Author

@jc2543 jc2543 Oct 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, this is just referring to the command string in the daemonset-linux file for matching purposes (this command is just making image tag replacements for in the azure-cns daemonset yaml thats already being used). The image we are using is azure-cni. We are able to swap both CNI/CNS images by deploying this daemonset.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we do "kubectl apply daemonset" instead?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we apply the daemonset in the next couple of lines, but first we have to update the yaml first with the image and args we want so that the cni image gets deployed.

@paulyufan2 paulyufan2 requested a review from jpayne3506 October 7, 2024 18:08
@paulyufan2 paulyufan2 added the ci Infra or tooling. label Oct 7, 2024
@github-actions
Copy link

This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the stale Stale due to inactivity. label Oct 31, 2024
@github-actions
Copy link

github-actions bot commented Nov 8, 2024

Pull request closed due to inactivity.

@github-actions github-actions bot closed this Nov 8, 2024
@github-actions github-actions bot deleted the chlochen/acnswiftpre2e3 branch November 8, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Infra or tooling. stale Stale due to inactivity.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants