-
Notifications
You must be signed in to change notification settings - Fork 260
ci: add swiftv2 Linux scenario to acn pr checks #3042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
.pipelines/pipeline.yaml
Outdated
| dummyClusterName: "swiftv2dummy" | ||
| dummyClusterType: "swiftv2-dummy-cluster-up" | ||
| dummyClusterDisplayName: Swiftv2 Multitenancy Dummy Cluster | ||
| scenario: westcentralus |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shall we pass a parameter here and in the future we can run it on other regions
.pipelines/pipeline.yaml
Outdated
| region: $(region) | ||
| sub: $(SUB_AZURE_NETWORK_AGENT_TEST) | ||
| svcConn: $(ACN_TEST_SERVICE_CONNECTION) | ||
| scenario: westcentralus |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
scenario is westcentralus, can you explain more about this flag meaning?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, it maps to a region/scenario configuration file that we use for swiftv2 runners
| sed -i '/containers:/{n;n;s/\(image\).*/\1: '"${CNS_IMAGE//\//\\/}"'/}' ./test/integration/manifests/cns/daemonset-linux.yaml | ||
| sed -i '/initContainers:/{n;n;s/\(image\).*/\1: '"${CNI_IMAGE//\//\\/}"'/}' ./test/integration/manifests/cns/daemonset-linux.yaml | ||
| sed -i '/- name: cni-installer/,/volumeMounts:/ { | ||
| /command: \["\/dropgz"\]/!b; a \ \ \ \ \ \ \ \ \ \ args:\n\ \ \ \ \ \ \ \ \ \ \ \ - deploy\n\ \ \ \ \ \ \ \ \ \ \ \ - --skip-verify\n\ \ \ \ \ \ \ \ \ \ \ \ - azure-vnet\n\ \ \ \ \ \ \ \ \ \ \ \ - -o\n\ \ \ \ \ \ \ \ \ \ \ \ - /opt/cni/bin/azure-vnet\n\ \ \ \ \ \ \ \ \ \ \ \ - azure-vnet-telemetry\n\ \ \ \ \ \ \ \ \ \ \ \ - -o\n\ \ \ \ \ \ \ \ \ \ \ \ - /opt/cni/bin/azure-vnet-telemetry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought dropgz is deprecated already from the repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, this is just referring to the command string in the daemonset-linux file for matching purposes (this command is just making image tag replacements for in the azure-cns daemonset yaml thats already being used). The image we are using is azure-cni. We are able to swap both CNI/CNS images by deploying this daemonset.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we do "kubectl apply daemonset" instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we apply the daemonset in the next couple of lines, but first we have to update the yaml first with the image and args we want so that the cni image gets deployed.
|
This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days |
|
Pull request closed due to inactivity. |
Reason for Change:
This PR adds the swiftv2 e2e pr checks to the Azure Container Networking PR pipeline. This is an initial PR, and needs BYOCNI enabled for swiftv2. Once we get that enabled, we will update the cluster creation script to prevent CNS/CNI images from reconciling.
Issue Fixed:
Requirements:
Notes: