fix: issue dhcp request on windows secondary interfaces #3047
Conversation
…t existing cni code include last error cause when cooldown function errors (discuss) for compatability use durations instead of millis correct usage of number retries vs number of runs create helper function for retrying in transparent vlan mode create wrapper method that makes all passed in errors temporary (retriable) errors
QxBytes
force-pushed
the
alew/dhcp-win
branch
2 times, most recently
from
59225e4 to
a10f0df
Compare
|
This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days |
|
This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days |
|
This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days |
|
This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days |
|
This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days |
|
This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days |
|
This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days |
|
This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days |
|
Pull request closed due to inactivity. |
Reason for Change:
We need to issue a dhcp request to the host in order to create a mapping for the secondary interface. The mapping allows for us to query the azure dns server on the secondary interface. The dhcp discover request occurs before the interface has the intended ip or is moved into the container namespace, but it does have an apipa autoconfigured ip. The auto assigned ip allows us to set the source ip of the packet so that the dhcp packet goes out on the interface that we want. We assume the interface always gets an auto configured ip. Then, once cni completes, we expect that secondary interface to be moved into the container.
Adds validation for nwCfg.Master since we issue exec commands with the field, so ensure this validation does not break anything else.
Reorganizes code into dhcp linux, windows and common.
Reorganizes retry logic into separate package
Confirm that we only run this code if we are on swiftv2 windows (is the nic type condition correct?). Confirmed yes.
Tested:
Limitations:
Issue Fixed:
Requirements:
Notes:
Related to #2989