feat: create a dummy NC to store secondary IPs in nodesubnet deployments with Cilium #3057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santhoshmprabhu
changed the title
…ure-container-networking into sanprabhu/cilium-node-subnet-nc
…ure-container-networking into sanprabhu/cilium-node-subnet-nc
Contributor
Author
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
timraymond
reviewed
Oct 8, 2024
…ure-container-networking into sanprabhu/cilium-node-subnet-nc
Contributor
Author
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…ure-container-networking into sanprabhu/cilium-node-subnet-nc
Contributor
Author
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
tamilmani1989
approved these changes
Oct 17, 2024
sivakami-projects
pushed a commit
that referenced
this pull request
Oct 23, 2025
…nts with Cilium (#3057) * WIP * chore: first set of files for nodesubnet nc * chore: add ipam reconciler interface * feat: add ability to save fake nodesubnet nc * fix: make linter happy, cleanup * chore: cleanup * fix: make linter happy * fix: make linter happy * fix: fix failing test * refactor: remove public ipam reconciler interface * fix: fix compile after unexporting interface * refactor: break down IPAM reconciliation to address Evan's comment * chore: fix comment * fix:make linter happy * fix: Address comments, add todo for Evan's feedback * Address comments * fix: fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
This PR introduces a "fake NC" that we use to integrate IPs for NodeSubnet into the CNS code. The members in this "NC" except the secondary IPs are hard-coded. These NCs are used to populate the CNS state in two situations -
In this PR, we have some of the APIs that will allow the 2 scenarios above to be implemented. Specifically, we have an API to create an NC request using a give list of secondary IPs, which will then be used to update the CNS state after a fetch from NMAgent. We also have an StateReconciler interface that creates functions for populating the CNS state from the on-disk statefile.
Issue Fixed:
NA
Requirements:
Notes: