feat: support for cilium + nodesubnet #3073
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santhoshmprabhu
added
work-in-progress
cns
…-container-networking into sanprabhu/cilium-node-subnet
santhoshmprabhu
requested review from
jpayne3506,
rbtr,
tamilmani1989,
timraymond and
vipul-21
Contributor
Author
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vipul-21
reviewed
Oct 22, 2024
.pipelines/singletenancy/cilium-nodesubnet/cilium-nodesubnet-e2e-step-template.yaml
Outdated
Show resolved
Hide resolved
timraymond
reviewed
Oct 22, 2024
Co-authored-by: Timothy J. Raymond <[email protected]> Signed-off-by: Santhosh Prabhu <[email protected]>
Co-authored-by: Timothy J. Raymond <[email protected]> Signed-off-by: Santhosh Prabhu <[email protected]>
Contributor
Author
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…-container-networking into sanprabhu/cilium-node-subnet
Contributor
Author
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
LGTM. Delegating approval to others with outstanding comments. |
Contributor
Author
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
tamilmani1989
approved these changes
Nov 1, 2024
Contributor
Author
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
behzad-mir
approved these changes
Nov 4, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Contributor
Author
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
sivakami-projects
pushed a commit
that referenced
this pull request
Oct 23, 2025
* feat: support for cilium + nodesubnet * fix: make linter happy * fix: make linter happy * fix: make linter happy * test: add test for nodesubnet * chore: add missing files * nicer comment * chore: fix comment typo * fix: update cns/restserver/nodesubnet.go Co-authored-by: Timothy J. Raymond <[email protected]> Signed-off-by: Santhosh Prabhu <[email protected]> * fix: update cns/restserver/restserver.go Co-authored-by: Timothy J. Raymond <[email protected]> Signed-off-by: Santhosh Prabhu <[email protected]> * refactor: address comments * fix: address comments * chore:comment cleanup * fix: do not use bash in ip config update * fix: address comments * fix: make linter happy * chore: move pipeline changes out * test: more elaborate test including checks on IP pool state * fix: use comments suitable for documentation Co-authored-by: Timothy J. Raymond <[email protected]> Signed-off-by: Santhosh Prabhu <[email protected]> * chore: address comments * chore:make linter happy * fix: address comments * chore: typo * chore: address comments * fix: update comments --------- Signed-off-by: Santhosh Prabhu <[email protected]> Co-authored-by: Timothy J. Raymond <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
This PR completes the implementation of CNS support for nodesubnet, so that we may use Cilium with nodesubnet. This PR includes the following changes:
The changes have been validated with E2E runs, though the pipeline changes are to be merged in a separate PR (#3083).
Issue Fixed:
Cilium nodesubnet support
Requirements:
Notes: