-
Notifications
You must be signed in to change notification settings - Fork 260
feat: adding stateless CNI support for ACI #3085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
LGTM. we tested this in an integration environment with ACI and it solved the issue we faced |
QxBytes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you add the details of the special case in the pr description (like the timeline of events and why there is no entry in the cns state by the time we call update endpoint helper)-- I thought the endpoint state is usually populated in updateEndpointState in cns, unless we don't request ips? Is InfraContainerID (in update endpoint state) typically equal to endpointID (in update endpoint helper)?
DOne |
tamilmani1989
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we write UT for this case
8b76b55 to
a0d5808
Compare
Done |
152aeee to
ee27d1a
Compare
96cf491 to
b0d5a10
Compare
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
* feat: adding stateless CNI support for ACI * fix:adding unit test * addressing the comments
feat: adding stateless CNI support for ACI>
New entry in CNS statefile will be added for a container upon updateEndpoint request if the entry does not already exist. This covers a special case for ACI.
In ACI the CNS path to allocate IP address and send goalstate is different than CNS IPAM for Cilium and azure-cni for AKS. As a result, the endpoint entry for statefile is not getting create upon IP allocation and this fix will create the whole entry when CNI send updateEndpoint API request to CNS.
Notes: