Adding availability zone to nnc spec #3092
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thatmattlong
requested changes
Oct 29, 2024
Collaborator
thatmattlong
left a comment
thatmattlong
left a comment
There was a problem hiding this comment.
let's make the az property optional
ramiro-gamarra
force-pushed
the
add-availability-zone-to-nnc
branch
from
090bbca to
05f5411
Compare
thatmattlong
approved these changes
Oct 30, 2024
Contributor
Author
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
sivakami-projects
pushed a commit
that referenced
this pull request
Oct 23, 2025
* adding availability zone to nnc spec * adding optional kubebuilder annotation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
In order to communicate the availability zone for ncs from the virtual machine where they are placed, we first need to expand the nnc definition to include the az in its status. Population will be handled in a subsequent PR.
Issue Fixed:
Requirements:
Notes: