Skip to content

Conversation

@camrynl
Copy link
Contributor

@camrynl camrynl commented Oct 30, 2024

Reason for Change:
use nodepool scale instead of vmss scale since this is the supported way to scale down the nodepool in AKS clusters

Issue Fixed:

Requirements:

Notes:

@camrynl camrynl requested a review from a team as a code owner October 30, 2024 21:54
@camrynl camrynl requested a review from thatmattlong October 30, 2024 21:54
@camrynl
Copy link
Contributor Author

camrynl commented Oct 30, 2024

/azp run Azure Container Networking PR

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

vipul-21
vipul-21 previously approved these changes Oct 30, 2024
@camrynl
Copy link
Contributor Author

camrynl commented Oct 30, 2024

/azp run Azure Container Networking PR

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@camrynl camrynl enabled auto-merge November 1, 2024 16:27
Copy link
Contributor

@jshr-w jshr-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@camrynl camrynl added this pull request to the merge queue Nov 1, 2024
Merged via the queue into master with commit 2938c1f Nov 1, 2024
19 of 22 checks passed
@camrynl camrynl deleted the camrynl/scaledowncil branch November 1, 2024 19:27
sivakami-projects pushed a commit that referenced this pull request Oct 23, 2025
* nodepool scale down instead of vmss scale

* replace make target for scale-vmss with scale-nodes

* set scale down to 5

* add nodepool name to scale target
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants