Remove l2bridge checker on windows and l2tunnel mode #3113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulyufan2
force-pushed
the
simplifyCNIConflist
branch
from
18942f1 to
355c02a
Compare
paulyufan2
force-pushed
the
simplifyCNIConflist
branch
from
355c02a to
1393985
Compare
QxBytes
reviewed
Nov 8, 2024
Contributor
QxBytes
left a comment
QxBytes
left a comment
There was a problem hiding this comment.
could we add a unit test where we pass in some value to nwInfo (type: EndpointInfo) and then call configure endpoint, ensuring that the resulting hcn network type is always l2 bridge?
paulyufan2
force-pushed
the
simplifyCNIConflist
branch
from
1393985 to
e838c65
Compare
QxBytes
previously approved these changes
Nov 11, 2024
Contributor
QxBytes
left a comment
QxBytes
left a comment
There was a problem hiding this comment.
Confirmed with paul that l2tunnel is not used anywhere. azure-windows-multitenancy.conflist is not modified as it could not be readily tested. Only time networking mode is not bridge in windows is if the nic type is a particular value. Linux side should be unaffected.
paulyufan2
force-pushed
the
simplifyCNIConflist
branch
from
1d52281 to
07de10b
Compare
Contributor
Author
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
QxBytes
approved these changes
Nov 11, 2024
paulyufan2
force-pushed
the
simplifyCNIConflist
branch
from
50c8b25 to
7555862
Compare
Collaborator
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rbtr
approved these changes
Nov 11, 2024
Collaborator
rbtr
left a comment
rbtr
left a comment
There was a problem hiding this comment.
no objection to the CNS changes
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 11, 2024
* remove l2bridge checker and l2tunnel mode * fix l2bridge type * fix the comment to add an UT to ensure hcn network type is always l2bridge * go format to fix the linter issue
sivakami-projects
pushed a commit
that referenced
this pull request
Oct 23, 2025
* remove l2bridge checker and l2tunnel mode * fix l2bridge type * fix the comment to add an UT to ensure hcn network type is always l2bridge * go format to fix the linter issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
This PR is to simplify windows l2bridge mode and remove l2tunnel mode from the system.
Issue Fixed:
Requirements:
Notes: