Remove bridgeName field from CNI windows conflist files #3135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulyufan2
force-pushed
the
cleanupcniwindowsconfig
branch
2 times, most recently
from
e91aaf7 to
72a8bd7
Compare
QxBytes
reviewed
Nov 12, 2024
Contributor
QxBytes
left a comment
QxBytes
left a comment
There was a problem hiding this comment.
So just confirming that "bridge" (the field) isn't used in windows, and mode will default to bridge if it is not specified? Could you also run the full pipeline with this change?
Contributor
Author
|
@QxBytes pipeline passes |
paulyufan2
force-pushed
the
cleanupcniwindowsconfig
branch
2 times, most recently
from
a1c4831 to
69e6239
Compare
QxBytes
approved these changes
Nov 13, 2024
QxBytes
approved these changes
Nov 13, 2024
Contributor
QxBytes
left a comment
QxBytes
left a comment
There was a problem hiding this comment.
On windows, a reference search for the bridgeName field of endpoint info does not reveal any usages. it seems like you're only modifying windows conflists so there shouldn't be any effect.
QxBytes
approved these changes
Nov 13, 2024
paulyufan2
force-pushed
the
cleanupcniwindowsconfig
branch
from
69e6239 to
abe6d77
Compare
Contributor
Author
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
sivakami-projects
pushed a commit
that referenced
this pull request
Oct 23, 2025
remove bridgeName field from CNI windows conflist files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
This PR is to cleanup windows cni config file to remove bridgeName fields
Issue Fixed:
Requirements:
Notes: