[NPM] Update NPM base image to Distroless #3143
Conversation
rejain456
force-pushed
the
jainriya/distroless1
branch
from
491fb4c to
44a8801
Compare
rejain456
force-pushed
the
jainriya/distroless1
branch
from
44a8801 to
eba581e
Compare
| az aks create --no-ssh-key \ | ||
| --resource-group $(RESOURCE_GROUP) \ | ||
| --name $(AZURE_CLUSTER) \ | ||
| --network-plugin azure |
| --resource-group $(RESOURCE_GROUP) \ | ||
| --name $(AZURE_CLUSTER) \ | ||
| --network-plugin azure | ||
| ----os-sku $(OS_SKU) |
|
@rbtr Do you have any advice for the docker file? |
|
This looks good, it's very similar to what I did for CNS |
| ARG VERSION | ||
| ARG NPM_AI_PATH | ||
| ARG NPM_AI_ID | ||
| RUN apt-get update && apt-get install -y iptables ipset ca-certificates conntrack grep && apt-get autoremove -y && apt-get clean |
There was a problem hiding this comment.
make this a separate build stage to keep the concerns distinct and so it can parallelize - let the Go builder only build Go and we'll make an iptables target to get those bits.
move to something like
FROM mariner-core AS iptables
RUN tdnf install -y iptables etcthen change your copies to --from iptables
|
This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days |
|
This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days |
|
This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days |
|
Pull request closed due to inactivity. |
|
This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days |
|
Pull request closed due to inactivity. |
Reason for Change:
Updated NPM base image to Distroless.
Issue Fixed:
Updating npm base image eliminated the segmentation error we would see with ~20k chains added in iptables-nft with base image Ubuntu 20.04
Requirements:
Notes: