update for new home az contract from nma #3151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timraymond
reviewed
Nov 15, 2024
timraymond
requested changes
Nov 15, 2024
ZetaoZhuang
requested review from
smittal22 and
timraymond
and removed request for
timraymond
msvik
reviewed
Nov 19, 2024
msvik
reviewed
Nov 19, 2024
ZetaoZhuang
requested review from
msvik and
timraymond
and removed request for
timraymond
ZetaoZhuang
requested review from
timraymond
and removed request for
timraymond
The NMAgent team has added an API version field to the HomeAZ response as a means to indicate whether or not certain bugfixes have been applied. Since this API Version field conveys no meaningful information, this adds an "AppliedFixes" field to the response to make it meaningful to users.
This is to ensure that these are prett-printed properly for clients that log them.
This alters the response to use the ContainsFixes method added to the HomeAzResponse. Rather than using API Version directly, the more semantically-meaningful constants from the nmagent package are used instead to indicate whether or not some bugfixes have been applied.
timraymond
previously approved these changes
Dec 16, 2024
smittal22
reviewed
Dec 19, 2024
smittal22
reviewed
Dec 19, 2024
Contributor
smittal22
left a comment
smittal22
left a comment
There was a problem hiding this comment.
Let me know once you address these.
Contributor
Author
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ZetaoZhuang
dismissed stale reviews from smittal22 and timraymond
via
d238c53
smittal22
approved these changes
Dec 19, 2024
Contributor
Author
|
Hey @timraymond , can you approve again? Thanks |
Contributor
Author
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
timraymond
approved these changes
Dec 19, 2024
sivakami-projects
pushed a commit
that referenced
this pull request
Oct 23, 2025
* update for new home az contract * fix lint * address comment * fix lint * address comment * Add "AppliedFixes" to HomeAzResponse The NMAgent team has added an API version field to the HomeAZ response as a means to indicate whether or not certain bugfixes have been applied. Since this API Version field conveys no meaningful information, this adds an "AppliedFixes" field to the response to make it meaningful to users. * Implement fmt.Stringer for HomeAZFix This is to ensure that these are prett-printed properly for clients that log them. * Use nmagent.(HomeAZResponse).ContainsFixes in CNS This alters the response to use the ContainsFixes method added to the HomeAzResponse. Rather than using API Version directly, the more semantically-meaningful constants from the nmagent package are used instead to indicate whether or not some bugfixes have been applied. * add nma client test * fix lint * fix UTs --------- Co-authored-by: Timothy J. Raymond <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
NMA introduces a new field apiVersion in home az endpoint for the purpose of fixing the ipv6 issue in swift azr, we need to make changes on cns to correspond to this contract change.
Issue Fixed:
Requirements:
Notes: