fix: return error on interface not found and always clean up snat ep #3226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
timraymond
approved these changes
Dec 3, 2024
tamilmani1989
approved these changes
Dec 4, 2024
sivakami-projects
pushed a commit
that referenced
this pull request
Oct 23, 2025
…3226) * return error on interface not found and always clean up snat ep * modify snat client to accept interfaces for unit testing * address linter issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
If the interface is not found when querying for it in AllowHostToNC or vice versa, the error is ignored, leading to a potential panic if we try to access the interface (which would be nil). This PR checks the error and returns it if it is not found, avoiding the panic. Additionally, if there is a failure in deleting one of the interfaces for an endpoint, this PR will still attempt to clean up associated snat interface (previously an error during the cleanup process would cause the snat endpoint not to be cleaned up).
Issue Fixed:
Requirements:
Notes:
Green run: https://msazure.visualstudio.com/One/_build/results?buildId=109439035&view=results