[NPM Lite] Added DefaultDeny in PNI + MTPNC CRD's #3265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
thatmattlong
requested changes
Dec 19, 2024
Collaborator
thatmattlong
left a comment
thatmattlong
left a comment
There was a problem hiding this comment.
let's make the new fields optional since existing CRDs won't have it set
crd/multitenancy/manifests/multitenancy.acn.azure.com_multitenantpodnetworkconfigs.yaml
Outdated
Show resolved
Hide resolved
crd/multitenancy/manifests/multitenancy.acn.azure.com_podnetworkinstances.yaml
Outdated
Show resolved
Hide resolved
Contributor
Author
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
thatmattlong
approved these changes
Jan 2, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
sivakami-projects
pushed a commit
that referenced
this pull request
Oct 23, 2025
* updated mtpnc crd and pni crd by adding default deny acl bool field * updated pni crd * updated mtpnc crd * updated bool to boolean in crd * updated schema/lowercased default dent * fixing crd pipeline error * tset * revert * resolved nits from pr * resolved crg gen failing issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
As part of adding default deny so pods can't communicate with one another when network policies are not present, this pr is part 1 which updates the pni crd and mtpnc crd with adding a default deny acl bool field.
Test:
Confirmed when default deny is not added as a field or is added as a field and set to false, mtpnc displays Default Deny ACL : false as shown below
Confirmed when default deny is added as a field and set to true, mtpnc displays Default Deny ACL : true as shown below
Issue Fixed:
Requirements:
Notes: