Updating CNS to work with a Dualstack NC #3288
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjdenney
force-pushed
the
V6PrefixDesign
branch
3 times, most recently
from
55f5522 to
705c09e
Compare
rjdenney
force-pushed
the
V6PrefixDesign
branch
from
49cc3cd to
88959a1
Compare
|
This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days |
|
Pull request closed due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
This PR allows for us to retrieve a dualstack NC from the NNC. A new enum has been added for IP family that will update when CNS reads an NC and populates the ipam pool. In ipam we will then retrieve the number of IPs needed according to the number of IP families found across all NCs. This work is to support dualstack NCs which will be used for Vnet Prefix dualstack and will still support the two NC solution used for dualstack overlay.
Also adds UT scenarios for ipam to include dualstack NC tests along with single stack NCs and two NCs of different IP families.
Issue Fixed:
Requirements:
Notes: