fix: route issues on Swiftv2 Windows #3375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QxBytes
previously approved these changes
Jan 29, 2025
paulyufan2
changed the title
Contributor
Author
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…re-container-networking into coderefactorcnsswiftv2
Signed-off-by: Paul Yu <[email protected]>
tamilmani1989
approved these changes
Feb 3, 2025
kmurudi
approved these changes
Feb 4, 2025
Contributor
kmurudi
left a comment
kmurudi
left a comment
There was a problem hiding this comment.
lgtm, pending testing/validation on cluster
Contributor
Author
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
QxBytes
approved these changes
Feb 4, 2025
sivakami-projects
pushed a commit
that referenced
this pull request
Oct 23, 2025
* updated CNS for adding default deny acl's * added infra nic change * added unit tests * resolved pr comments * updating to fix github checks * added logging lines * removing unnecessary logging lines * removed cni circular dependency * switch from having consts to making them inline * cns changes based on update to network container contrac * fixed spelling * updated unit test * updated test * reverted a comment * updated name of function * changed policy type * added a new line * resolving pr comments * resolving pr comments * re-added back * updated creating acl code to make it more modularized * fixed golint errors * fixed golint * added tests * fixed spelling * moved an assertion line * reformated creating acl's * refactored code per pr comments * fixed lint * moved GetEndpointPolicy so that it is only run on init * updated code * updated error message * updated getEndpointPolicy placement * updated comment * fixed golint issues * refactored * fixed comments * updated return inline * updated unit test returns * corrected the go lint of file * fix swiftv2 route issues * ut fix * fix linter issue * fix comments * fix comments * fix comments * enhance comment * rename func names --------- Signed-off-by: Paul Yu <[email protected]> Co-authored-by: rejain456 <[email protected]> Co-authored-by: rejain456 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
This is the long term solution to fix Swiftv2 Windows Routes issues to make sure windows cns gets all required cidrs from AKS.
Fixes include:
1.Windows CNS gets infravnet/pod/node cidrs from configs
2.Add these routes and send them to the CNI
Issue Fixed:
In Linux Swiftv2, CNS fetches infravnet/pod/node cidrs from the node's envs set by AKS; we should do same thing for Windows;
Requirements:
This PR is based on npm-lite PR with cns middleware refactoring and linked with this PR:
#3205
Notes: