Skip to content

feat: templatize dockerfile base images and auto update #3397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 17, 2025
Merged

feat: templatize dockerfile base images and auto update #3397

merged 3 commits into from
Apr 17, 2025

Conversation

@rbtr
Copy link
Collaborator

@rbtr rbtr commented Feb 5, 2025

Reason for Change:

Templatize Dockerfiles so that base image updates may be automated

Issue Fixed:

Requirements:

Notes:

@rbtr rbtr requested review from a team as code owners February 5, 2025 21:01
@rbtr rbtr requested a review from paulyufan2 February 5, 2025 21:01
@rbtr
Copy link
Collaborator Author

rbtr commented Feb 5, 2025

/azp run Azure Container Networking PR

@azure-pipelines
Copy link

azure-pipelines bot commented Feb 5, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@rbtr rbtr force-pushed the feat/dockerfile-templates branch from e23ff36 to d8e0639 Compare February 5, 2025 22:15
@rbtr
Copy link
Collaborator Author

rbtr commented Feb 5, 2025

/azp run Azure Container Networking PR

@azure-pipelines
Copy link

azure-pipelines bot commented Feb 5, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@nddq
Copy link
Member

nddq commented Feb 6, 2025 •
edited
Loading

i did not have any luck with peter-evans/create-pull-request@v5 here since making pull request from GHA is disabled org-wide
image

@rbtr
Copy link
Collaborator Author

rbtr commented Feb 6, 2025

i did not have any luck with peter-evans/create-pull-request@v5

well, that's disappointing. so this is not automatable.

@rbtr rbtr force-pushed the feat/dockerfile-templates branch from d8e0639 to c156ea5 Compare February 6, 2025 16:18
@rbtr
Copy link
Collaborator Author

rbtr commented Feb 6, 2025

/azp run Azure Container Networking PR

@azure-pipelines
Copy link

azure-pipelines bot commented Feb 6, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@rbtr rbtr force-pushed the feat/dockerfile-templates branch from c156ea5 to 5bdc089 Compare February 6, 2025 16:19
@rbtr
Copy link
Collaborator Author

rbtr commented Feb 6, 2025

/azp run Azure Container Networking PR

@azure-pipelines
Copy link

azure-pipelines bot commented Feb 6, 2025

Azure Pipelines successfully started running 1 pipeline(s).

timraymond
timraymond reviewed Feb 7, 2025
View reviewed changes
timraymond
timraymond previously approved these changes Feb 12, 2025
View reviewed changes
@rbtr rbtr enabled auto-merge February 12, 2025 23:48
@rbtr rbtr force-pushed the feat/dockerfile-templates branch from 5bdc089 to 36d5a70 Compare February 13, 2025 00:06
rbtr added 3 commits February 27, 2025 21:31
@rbtr
feat: templatize dockerfile base images and auto update
1435c96 
Signed-off-by: Evan Baker <[email protected]>
@rbtr
add cni
04d8d2f 
Signed-off-by: Evan Baker <[email protected]>
@rbtr
update images
27fb93c 
Signed-off-by: Evan Baker <[email protected]>
@rbtr rbtr force-pushed the feat/dockerfile-templates branch from 36d5a70 to 27fb93c Compare February 27, 2025 21:32
@rbtr
Copy link
Collaborator Author

rbtr commented Feb 28, 2025

/azp run Azure Container Networking PR

@azure-pipelines
Copy link

azure-pipelines bot commented Feb 28, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@rbtr rbtr self-assigned this Feb 28, 2025
@rbtr rbtr added dependencies Dependencies only. ci Infra or tooling. labels Feb 28, 2025
@github-actions
Copy link

github-actions bot commented Mar 15, 2025

This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the stale Stale due to inactivity. label Mar 15, 2025
@rbtr rbtr removed the stale Stale due to inactivity. label Mar 17, 2025
@rbtr rbtr mentioned this pull request Mar 20, 2025
Closed
@github-actions
Copy link

github-actions bot commented Apr 1, 2025

This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the stale Stale due to inactivity. label Apr 1, 2025
@rbtr rbtr removed the stale Stale due to inactivity. label Apr 1, 2025
@github-actions
Copy link

github-actions bot commented Apr 16, 2025

This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the stale Stale due to inactivity. label Apr 16, 2025
@thatmattlong thatmattlong removed the stale Stale due to inactivity. label Apr 16, 2025
@rbtr rbtr added this pull request to the merge queue Apr 16, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 16, 2025
@rbtr rbtr added this pull request to the merge queue Apr 16, 2025
Merged via the queue into master with commit 81351cb Apr 17, 2025
19 checks passed
@rbtr rbtr deleted the feat/dockerfile-templates branch April 17, 2025 02:10
sivakami-projects pushed a commit that referenced this pull request Oct 23, 2025
@rbtr
feat: templatize dockerfile base images and auto update (#3397)
305a38d 
* feat: templatize dockerfile base images and auto update

Signed-off-by: Evan Baker <[email protected]>

* add cni

Signed-off-by: Evan Baker <[email protected]>

* update images

Signed-off-by: Evan Baker <[email protected]>

---------

Signed-off-by: Evan Baker <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thatmattlong thatmattlong thatmattlong approved these changes

@paulyufan2 paulyufan2 paulyufan2 approved these changes

@timraymond timraymond timraymond left review comments

Assignees

@rbtr rbtr

Labels

ci Infra or tooling. dependencies Dependencies only.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@rbtr @nddq @timraymond @thatmattlong @paulyufan2