ci: split dualstack and overlay e2e tests by operating system #3431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
.pipelines/pipeline.yaml:384
- The Windows dualstack overlay job name is inconsistent with its later dependency reference which uses 'windows_dualstackoverlay_e2e'. Consider standardizing the Windows naming convention (e.g. renaming to 'windows_dualstackoverlay_e2e') so that dependency resolution works as expected.
name: "win_dualstackoverlay_e2e"
jpayne3506
reviewed
Feb 19, 2025
jpayne3506
reviewed
Feb 19, 2025
jpayne3506
requested changes
Feb 19, 2025
Contributor
jpayne3506
left a comment
jpayne3506
left a comment
There was a problem hiding this comment.
Core .yaml changes lgtm. I like the makefile changes, but let's keep our usage consistent throughout.
jpayne3506
approved these changes
Feb 19, 2025
Contributor
jpayne3506
left a comment
jpayne3506
left a comment
There was a problem hiding this comment.
Plan to clean up the makefile in a follow-on PR?
split dualstack remove windows to debug remove dup remove unknown stage remove windows from cluster name add windows vm size add windows and linux specific parameters make hybrid windows test on windows only dualstack
fix win cluster overlay always being linux only
…g on cluster create
QxBytes
force-pushed
the
alew/split-dualstack
branch
from
8916407 to
a44e0ff
Compare
Contributor
Author
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
behzad-mir
approved these changes
Feb 19, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
sivakami-projects
pushed a commit
that referenced
this pull request
Oct 23, 2025
* split dualstack e2e tests by os split dualstack remove windows to debug remove dup remove unknown stage remove windows from cluster name add windows vm size add windows and linux specific parameters make hybrid windows test on windows only dualstack * split overlay e2e tests by os fix win cluster overlay always being linux only * pick: increase load test (control plane scale) timeout * remove if structure since win nodepool should never start off existing on cluster create * add aliases for new cluster types for compatability * address feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Splits dualstack and overlay E2E testing stages into stages dedicated to each operating system.
Dualstack E2E --> Dualstack Windows E2E and Dualstack Linux E2E
Overlay E2E --> Overlay Windows E2E and Overlay Linux E2E
Increases load test timeout from 30m to 40m due to timeouts (even though it seemed like the test was progressing)
Issue Fixed:
Dualstack and Overlay E2E stages take the longest to run in the pipeline and are the most likely to fail. These stages will fail faster if run in parallel.
Requirements:
Notes:
Green run: https://msazure.visualstudio.com/One/_build/results?buildId=115530896&view=results