fix: zapetw core With fields #3433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbtr
requested review from
neaggarwMS,
sivakami-projects,
timraymond and
vipul-21
rbtr
added
cns
Collaborator
Author
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
timraymond
reviewed
Feb 20, 2025
Signed-off-by: Evan Baker <[email protected]>
timraymond
approved these changes
Feb 20, 2025
Collaborator
Author
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
QxBytes
approved these changes
Feb 20, 2025
sivakami-projects
pushed a commit
that referenced
this pull request
Oct 23, 2025
fix: zapetw core with fields Signed-off-by: Evan Baker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug in the zapetw core where the extra
fieldsadded by callingWithwere not referenced when producing the log output.There was a private
fieldsslice in the Core struct, but it is not referenced anywhere. When a new Core is created inWith, thefieldswere copied over...but still not used.Now, instead, these fields are added to the Encoder. In the
Withcall, the Core is copied and the Encoder cloned, then new fields are added to the clone. This ensures that the new Fields in a derived logger/core do not propogate back up to the root logger...and also that they are used in producing the log output.Also includes some minor refactoring to fix naming and improve contracts.