ci: unify windows and linux cluster creation methods #3436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
There was a problem hiding this comment.
Copilot reviewed 5 out of 9 changed files in this pull request and generated no comments.
Files not reviewed (4)
- hack/aks/Makefile: Language not supported
- .pipelines/cni/load-test-templates/create-cluster-template.yaml: Evaluated as low risk
- .pipelines/cni/singletenancy/cniv1-template.yaml: Evaluated as low risk
- hack/aks/README.md: Evaluated as low risk
QxBytes
changed the title
jpayne3506
approved these changes
Feb 20, 2025
paulyufan2
approved these changes
Feb 21, 2025
rbtr
reviewed
Feb 21, 2025
| --no-ssh-key \ | ||
| --yes | ||
| @$(MAKE) set-kubeconf | ||
| ifeq ($(OS),windows) |
Collaborator
There was a problem hiding this comment.
Maybe a cluster having Windows nodes is...something we support and expect to happen and all of our test clusters should include?
Instead of being mostly ignored except for during the tests which specifically excercise Windows things?
WDYT @behzad-mir
sivakami-projects
pushed a commit
that referenced
this pull request
Oct 23, 2025
* cleanup makefile * remove windows user and password from cniv1 cluster * fix windows variable not propagating
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Fix inconsistent creation of windows and linux clusters, now all use OS makefile variable
Adding a windows nodepool waits for cluster to be in succeeded state instead of immediately failing
Issue Fixed:
Requirements:
Notes:
Release: https://msazure.visualstudio.com/One/_build/results?buildId=115700355&view=results
PR: https://msazure.visualstudio.com/One/_build/results?buildId=115758111&view=results