Skip to content

Conversation

@QxBytes
Copy link
Contributor

@QxBytes QxBytes commented Feb 26, 2025

fix check-shadowing not allowed

Reason for Change:

Backports #3432 into 1.5

Issue Fixed:

Requirements:

Notes:

fix check-shadowing not allowed
@QxBytes QxBytes added ci Infra or tooling. release/1.5 Change affects v1.5 release train labels Feb 26, 2025
@QxBytes QxBytes self-assigned this Feb 26, 2025
Copilot AI review requested due to automatic review settings February 26, 2025 19:03
@QxBytes QxBytes requested a review from a team as a code owner February 26, 2025 19:03
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

.golangci.yml:36

  • Replacing 'check-shadowing: true' with 'enable: - shadow' fixes the configuration error; please confirm that this change is consistent with the golangci-lint version used.
    enable:

@QxBytes
Copy link
Contributor Author

QxBytes commented Feb 26, 2025

/azp run Azure Container Networking PR

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@QxBytes QxBytes enabled auto-merge February 26, 2025 19:17
@QxBytes QxBytes added this pull request to the merge queue Feb 26, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 26, 2025
@QxBytes QxBytes added this pull request to the merge queue Feb 26, 2025
Merged via the queue into release/v1.5 with commit b3ee1dd Feb 27, 2025
14 checks passed
@QxBytes QxBytes deleted the alew/golint-fix-1-5 branch February 27, 2025 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Infra or tooling. release/1.5 Change affects v1.5 release train

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants