-
Notifications
You must be signed in to change notification settings - Fork 260
ci: add vnet scale cilium pipeline stage #3457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2277074 to
7a5b2e4
Compare
|
This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days |
|
This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
Files not reviewed (1)
- hack/aks/Makefile: Language not supported
Comments suppressed due to low confidence (2)
.pipelines/pipeline.yaml:241
- [nitpick] The displayName includes 'Ubuntu', which might be too specific if the test is applicable to multiple Linux distributions. Consider verifying if this specificity is intentional or if a more general name would better reflect the test's scope.
displayName: Cilium Podsubnet Vnet Scale Ubuntu
.pipelines/pipeline.yaml:244
- [nitpick] Ensure that the clusterName 'ciliumvscalee2e' follows the same naming convention as other cilium test clusters for consistency, especially compared to 'ciliume2e' in the earlier stage.
clusterName: "ciliumvscalee2e"
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
add vnet scale cilium stage
Reason for Change:
Adds cilium podsubnet vnet scale to the pipeline for e2e testing of cns and related components. Also updates the makefile to explicitly include pod allocation mode static block for targets that are intended to use vnet scale mode. Currently there seem to be makefile targets that are meant to create vnet scale clusters but upon creation and examination of their nncs, the mode only mentions
We expect
Issue Fixed:
Requirements:
Notes:
Will fail until relevant backend changes go in for creating vnet scale clusters with network plugin none
Done: https://msazure.visualstudio.com/One/_build/results?buildId=120192520&view=results