Skip to content

Conversation

@QxBytes
Copy link
Contributor

@QxBytes QxBytes commented Feb 26, 2025

Reason for Change:

Adds cilium podsubnet vnet scale to the pipeline for e2e testing of cns and related components. Also updates the makefile to explicitly include pod allocation mode static block for targets that are intended to use vnet scale mode. Currently there seem to be makefile targets that are meant to create vnet scale clusters but upon creation and examination of their nncs, the mode only mentions

kubernetes.azure.com/podnetwork-subnet=podnet
kubernetes.azure.com/podnetwork-type=vnet

We expect

kubernetes.azure.com/podnetwork-subnet=podnet
kubernetes.azure.com/podnetwork-type=vnetblock

Issue Fixed:

Requirements:

Notes:
Will fail until relevant backend changes go in for creating vnet scale clusters with network plugin none
Done: https://msazure.visualstudio.com/One/_build/results?buildId=120192520&view=results

@QxBytes QxBytes added the ci Infra or tooling. label Feb 26, 2025
@QxBytes QxBytes self-assigned this Feb 26, 2025
@QxBytes QxBytes force-pushed the alew/add-vnetscale-pipeline branch from 2277074 to 7a5b2e4 Compare February 26, 2025 23:53
@github-actions
Copy link

This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the stale Stale due to inactivity. label Mar 13, 2025
@QxBytes QxBytes removed the stale Stale due to inactivity. label Mar 18, 2025
@github-actions
Copy link

github-actions bot commented Apr 2, 2025

This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the stale Stale due to inactivity. label Apr 2, 2025
@QxBytes QxBytes removed the stale Stale due to inactivity. label Apr 3, 2025
@QxBytes QxBytes marked this pull request as ready for review April 4, 2025 19:12
Copilot AI review requested due to automatic review settings April 4, 2025 19:12
@QxBytes QxBytes requested a review from a team as a code owner April 4, 2025 19:12
@QxBytes QxBytes requested a review from msvik April 4, 2025 19:12
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • hack/aks/Makefile: Language not supported
Comments suppressed due to low confidence (2)

.pipelines/pipeline.yaml:241

  • [nitpick] The displayName includes 'Ubuntu', which might be too specific if the test is applicable to multiple Linux distributions. Consider verifying if this specificity is intentional or if a more general name would better reflect the test's scope.
displayName: Cilium Podsubnet Vnet Scale Ubuntu

.pipelines/pipeline.yaml:244

  • [nitpick] Ensure that the clusterName 'ciliumvscalee2e' follows the same naming convention as other cilium test clusters for consistency, especially compared to 'ciliume2e' in the earlier stage.
clusterName: "ciliumvscalee2e"

@QxBytes
Copy link
Contributor Author

QxBytes commented Apr 4, 2025

/azp run Azure Container Networking PR

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@QxBytes QxBytes added this pull request to the merge queue Apr 4, 2025
Merged via the queue into master with commit e503224 Apr 5, 2025
105 checks passed
@QxBytes QxBytes deleted the alew/add-vnetscale-pipeline branch April 5, 2025 00:57
sivakami-projects pushed a commit that referenced this pull request Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Infra or tooling.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants