fix: add vnetscale staticblock changes to aks makefile #3492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

rbtr wants to merge 1 commit into master from chore/vnet-scale

Collaborator

rbtr commented Mar 10, 2025

The vnetscale-* targets in the AKS Makefile did not have the flag which indicates StaticBlock allocation mode and therefore build normal dynamic podsubnet clusters instead.

Incidentally this means that the VnetScale E2E was not using a VnetScale cluster and this will fix that.


          fix: add vnetscale staticblock changes to aks makefile for e2e

696cab4

Signed-off-by: Evan Baker <[email protected]>

Copilot AI review requested due to automatic review settings

March 10, 2025 19:40

rbtr requested a review from a team as a code owner

March 10, 2025 19:40

rbtr requested a review from k-routhu

March 10, 2025 19:40

Copilot AI reviewed

View reviewed changes

Contributor

Copilot AI left a comment

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

rbtr requested review from nairashu, neaggarwMS, thatmattlong and vakalapa

March 10, 2025 19:41

rbtr self-assigned this

rbtr added cns fix vnet-scale labels

Collaborator Author

rbtr commented Mar 10, 2025

/azp run Azure Container Networking PR

azure-pipelines bot commented Mar 10, 2025

Azure Pipelines successfully started running 1 pipeline(s).

nairashu approved these changes

View reviewed changes

rbtr enabled auto-merge

March 10, 2025 20:09

vakalapa approved these changes

View reviewed changes

rbtr added this pull request to the merge queue

github-merge-queue bot removed this pull request from the merge queue due to no response for status checks

rbtr added this pull request to the merge queue

github-merge-queue bot removed this pull request from the merge queue due to failed status checks

Contributor

QxBytes commented Mar 12, 2025 •

edited

Loading

The vnet scale cluster in the e2e won't create until byocni + vnet scale is enabled in aks rp link to failure (Should be available once the next aks rp releases)

paulyufan2 enabled auto-merge

March 14, 2025 02:17

Contributor

paulyufan2 commented Mar 14, 2025

/azp run Azure Container Networking PR

azure-pipelines bot commented Mar 14, 2025

Azure Pipelines successfully started running 1 pipeline(s).

paulyufan2 added this pull request to the merge queue

github-merge-queue bot removed this pull request from the merge queue due to failed status checks

paulyufan2 added this pull request to the merge queue

jpayne3506 removed this pull request from the merge queue due to a manual request

Contributor

jpayne3506 commented Mar 14, 2025

Blocking CI/CD. Wait for next AKS-RP release before adding to merge queue.

github-actions bot commented Mar 29, 2025

This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days

github-actions bot added the stale label

rbtr removed the stale label

Contributor

nairashu commented Mar 31, 2025

/azp run Azure Container Networking PR

azure-pipelines bot commented Mar 31, 2025

Azure Pipelines successfully started running 1 pipeline(s).

github-actions bot commented Apr 15, 2025

This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days

github-actions bot added the stale label

rbtr removed the stale label

github-actions bot commented May 2, 2025

This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days

github-actions bot added the stale label

rbtr removed the stale label

github-actions bot commented May 17, 2025

This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days

github-actions bot added the stale label

github-actions bot commented May 25, 2025

Pull request closed due to inactivity.

github-actions bot closed this

github-actions bot deleted the chore/vnet-scale branch

May 25, 2025 00:01

rbtr added exempt-stale and removed stale labels

rbtr restored the chore/vnet-scale branch

May 29, 2025 22:54

rbtr reopened this

github-actions bot commented Jun 13, 2025

This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days

github-actions bot added the stale label

rbtr removed the stale label

rbtr closed this

rbtr deleted the chore/vnet-scale branch

November 19, 2025 16:55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

nairashu nairashu approved these changes

vakalapa vakalapa approved these changes

k-routhu Awaiting requested review from k-routhu k-routhu is a code owner automatically assigned from Azure/azure-sdn-members

neaggarwMS Awaiting requested review from neaggarwMS

thatmattlong Awaiting requested review from thatmattlong

Labels

cns exempt-stale fix vnet-scale