chore(deps): update dependencies in release/v1.4 #3493
Conversation
nddq
added
dependencies
There was a problem hiding this comment.
Pull Request Overview
This PR updates the project’s dependency toolchain to Go 1.24 while refreshing dependency versions managed by Dependabot and updating linting configurations.
- Update Go versions in GitHub workflow configs
- Update golangci-lint configuration with modified linter entries
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/crdgen.yaml | Update Go versions used for generating CRDs |
| .github/workflows/golangci.yaml | Update Go versions used for linting in workflows |
| .golangci.yml | Add new linters and replace an existing linter entry |
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
I'm not sure what the effect of the go.mod saying 1.23 (toolchain 1.24) and the builder images using MSFT Go 1.23 will be...I think it doesn't actually upgrade us to 1.24 |
hmm maybe you are right, ill just bump everything to 1.24 then |
|
linter is not recognizing NPM embedded structs coming from a different module 😕 |
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Pull Request Overview
This PR updates dependency versions for Azure Container Networking while also modernizing the Go linter and GitHub workflow configurations.
- Bumps dependency versions managed by dependabot.
- Updates Go versions in golangci-lint and CRD generation workflows.
- Hardcodes a specific Kubernetes version for the e2e test job.
Reviewed Changes
Copilot reviewed 45 out of 55 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| cns/networkcontainers/networkcontainers.go | Updated logger formatting for interface error messages. |
| cns/ipamclient/ipamclient.go | Standardized error formatting with string substitution. |
| cns/common/service.go | Applied consistent error logging format. |
| cni/network/network.go | Updated error messages in CNI functions to use string substitution. |
| .pipelines/cni/k8s-e2e/k8s-e2e-job-template.yaml | Changed dynamic Kubernetes version retrieval to a fixed version. |
| .golangci.yml | Modified linter rules to include copyloopvar and updated mnd/ gomnd rules. |
| .github/workflows/golangci.yaml | Now sets Go version using go.mod and uses the latest golangci-lint version. |
| .github/workflows/cyclonus-netpol-test.yaml | Updated Go version configuration to reference go.mod. |
| .github/workflows/cyclonus-netpol-extended-nightly-test.yaml | Updated Go version configuration to reference go.mod. |
| .github/workflows/crdgen.yaml | Simplified workflow configuration by removing matrix and using go.mod for Go version. |
Files not reviewed (10)
- .devcontainer/Dockerfile: Language not supported
- .devcontainer/devcontainer.json: Language not supported
- azure-ipam/go.mod: Language not supported
- azure-ipam/linux.Dockerfile: Language not supported
- azure-ipam/windows.Dockerfile: Language not supported
- build/tools/go.mod: Language not supported
- cni/build/windows.Dockerfile: Language not supported
- cni/linux.Dockerfile: Language not supported
- cni/windows.Dockerfile: Language not supported
- cns/linux.Dockerfile: Language not supported
Comments suppressed due to low confidence (3)
cns/common/service.go:64
- There is a typo in the error message: "Errror" should be corrected to "Error".
err := "[Azure CNS Errror] Initialize called with nil ServiceConfig."
cni/network/network.go:408
- The term "Interfacename" is likely a typo; consider updating it to "Interface name" for improved clarity.
errMsg := "Interfacename not specified in CNI Args"
cni/network/network.go:761
- The log message contains a grammar issue; "initialized" should be updated to "initialize".
log.Printf("failed to initialized cns client with URL %s: %v", opt.nwCfg.CNSUrl, err.Error())
|
This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days |
Signed-off-by: Quang Nguyen <[email protected]>
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days |
|
This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days |
|
Pull request closed due to inactivity. |
Reason for Change:
Issue Fixed:
Requirements:
Notes: