[PONv6] Add 3 new fields to NC. #3499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecigar13
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds three new fields to support Vnetblock routing scenarios in single tenant deployments by exposing additional network properties from CNS to NNC. Key changes include:
- Upgrading the controller-gen version in CRD manifests.
- Adding new CRD schema fields for defaultGatewayV6, macAddress, and primaryIPV6.
- Updating the NetworkContainer API type with new fields reflecting these changes.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crd/clustersubnetstate/manifests/acn.azure.com_clustersubnetstates.yaml | Upgraded controller-gen version annotation. |
| crd/nodenetworkconfig/manifests/acn.azure.com_nodenetworkconfigs.yaml | Added defaultGatewayV6, macAddress, and primaryIPV6 fields to the CRD schema. |
| crd/nodenetworkconfig/api/v1alpha/nodenetworkconfig.go | Added corresponding fields in the NetworkContainer API type. |
Comments suppressed due to low confidence (3)
crd/nodenetworkconfig/api/v1alpha/nodenetworkconfig.go:122
- [nitpick] Consider renaming 'PrimaryIPV6' to 'PrimaryIPv6' to follow conventional IPv6 formatting.
PrimaryIPV6 string `json:"primaryIPV6,omitempty"`
crd/nodenetworkconfig/api/v1alpha/nodenetworkconfig.go:126
- [nitpick] Consider renaming 'DefaultGatewayV6' to 'DefaultGatewayIPv6' for consistency with IPv6 naming conventions.
DefaultGatewayV6 string `json:"defaultGatewayV6,omitempty"`
crd/nodenetworkconfig/api/v1alpha/nodenetworkconfig.go:127
- [nitpick] Consider renaming 'MacAddress' to 'MACAddress' to align with standard acronym usage.
MacAddress string `json:"macAddress,omitempty"`
4a41379 to
febad81
Compare
ecigar13
force-pushed
the
keith/updateYaml
branch
from
febad81 to
d063299
Compare
ecigar13
changed the title
ecigar13
changed the title
Contributor
|
lgtm |
paulyufan2
approved these changes
Mar 14, 2025
Member
|
@rbtr anything i need to know about CRD changes? will this break anything between here and DNC? |
Contributor
Author
|
Hi @nddq , we only add new fields and DNC are not using these. We are making DNC PRs to publish to these fields. |
nddq
approved these changes
Mar 18, 2025
Member
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
sivakami-projects
pushed a commit
that referenced
this pull request
Oct 23, 2025
* feat: added 3 new fields on NC. Generated all CRD. * Revert version --------- Co-authored-by: keithnguyen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
This change allows DNC to publish
MACAddress,PrimaryIPV6andGatewayV6to NNC. CNS uses these fields to program routes in Swiftv2 Vnetblock scenario (single tenant)No code is using this fields. We have open DNC PR to publish to these fields.
CNS queries NIC
MACAddressagainst the IDMS API to ensure Swift NIC is programmed.Design doc:
https://microsoft.sharepoint.com/:w:/t/Aznet/EZy1F1lEUZpNiPwk6JsUtvcBHapTeO4yNEI6EMUxjElXnA?e=6JaEEl
Issue Fixed:
Requirements:
Notes: