fix: do not return a StripPrefix handler when building checker #3559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
already doing the strip prefix https://github.com/tyler-lloyd/azure-container-networking/blob/40b6c443d62321ee61c134bf6573ed2de9813d50/cns/healthserver/server.go#L15 so doing it inside check builder is redunant and causes the /healthz endpoint to return a 404
Collaborator
|
/azp run Azure Container Networking PR |
rbtr
approved these changes
Apr 3, 2025
|
Azure Pipelines successfully started running 1 pipeline(s). |
nddq
approved these changes
Apr 4, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
paulyufan2
approved these changes
Apr 4, 2025
sivakami-projects
pushed a commit
that referenced
this pull request
Oct 23, 2025
* fix: do not return a StripPrefix handler when building checker already doing the strip prefix https://github.com/tyler-lloyd/azure-container-networking/blob/40b6c443d62321ee61c134bf6573ed2de9813d50/cns/healthserver/server.go#L15 so doing it inside check builder is redunant and causes the /healthz endpoint to return a 404 * chore: tabs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
already doing the strip prefix https://github.com/tyler-lloyd/azure-container-networking/blob/40b6c443d62321ee61c134bf6573ed2de9813d50/cns/healthserver/server.go#L15
so doing it inside check builder is redunant and causes the /healthz endpoint to return a 404
Issue Fixed:
Requirements:
Notes: