Skip to content

Conversation

@rbtr
Copy link
Collaborator

@rbtr rbtr commented Apr 4, 2025

backport of HNS restart fixes #3529, #3540

Copilot AI review requested due to automatic review settings April 4, 2025 23:22
@rbtr rbtr requested a review from a team as a code owner April 4, 2025 23:22
@rbtr rbtr requested a review from hemanthmalla April 4, 2025 23:22
@rbtr rbtr self-assigned this Apr 4, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

platform/os_windows.go:277

  • Ensure that the 'time' package is imported since it is used for timeout and ticker functions in tryStartServiceFn and tryStopServiceFn.
deadline, cancel := context.WithTimeout(ctx, 90*time.Second)

@rbtr rbtr added cns Related to CNS. fix Fixes something. release/1.5 Change affects v1.5 release train labels Apr 4, 2025
@rbtr rbtr requested a review from behzad-mir April 10, 2025 21:14
@rbtr
Copy link
Collaborator Author

rbtr commented Apr 10, 2025

/azp run Azure Container Networking PR

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@github-actions
Copy link

This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the stale Stale due to inactivity. label Apr 25, 2025
@rbtr rbtr removed the stale Stale due to inactivity. label Apr 30, 2025
@rbtr rbtr added this pull request to the merge queue May 1, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 1, 2025
@rbtr rbtr added this pull request to the merge queue May 1, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 1, 2025
@jpayne3506 jpayne3506 added this pull request to the merge queue May 1, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 1, 2025
@rbtr rbtr added this pull request to the merge queue May 1, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 1, 2025
@rbtr rbtr added this pull request to the merge queue May 1, 2025
Merged via the queue into release/v1.5 with commit c236eaf May 2, 2025
14 checks passed
@rbtr rbtr deleted the backport/v1.5/hns-restart-fix branch May 2, 2025 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cns Related to CNS. fix Fixes something. release/1.5 Change affects v1.5 release train

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants