revert: [NPM] Remove hostUsers Configuration #3613
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* removed all logs from npm dataplane (except error/warning logs) * removed all logs from npm controller (except error/warning logs) * restored logs that are ununused by current npm (v2) * removed test files * resolved comments * keep log related to reconciling chain placement when the chain is not in the right place * added bootup logs back * Removed two more noisy logs * Add loglevel config option when printing application insight logs * Updated all non-error/warning logs to commented out and with a vap TODO * fixed typo * small typo fix * updated configmap with loglevel * updated default value * added a default value for loglevel * fixed typo in json * removed comma * changed loglevel to info in configmap * add a short sleep in TestNetPolInBackgroundSkipAddAfterRemove * test remove dataplane changes to see if race condition fixes * Revert "test remove dataplane changes to see if race condition fixes" This reverts commit 08697eb. * test * Revert "test" This reverts commit 449c2af. * test * update dataplane to test if changes are flagged in race * added stop channels to unit tests to avoid race condtiions * add non noisy logs back * increased time * revert time change after RunPeriodicTasks * test with 1000 seconds * 5000 milliseconds * tweaked the delay * update to 1500 for defer * increased to 1500 * increase to 2000 * removed kubernetes
rayaisaiah
requested review from
a team,
ZetaoZhuang,
ashvindeodhar,
camrynl,
paulyufan2,
rbtr and
thatmattlong
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR reverts the previous removal of the hostUsers configuration and updates multiple YAML pipeline files and CI workflows. Key changes include:
- Upgrading all AzureCLI tasks from version 1 to version 2.
- Renaming and updating variables (e.g., replacing CILIUM_VERSION_TAG with CILIUM_VERSION_TAG_V1_5) to match the intended configuration.
- Bumping Go versions and updating related tool versions in CI workflows.
Reviewed Changes
Copilot reviewed 200 out of 202 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| .pipelines/cni/lsg/lsg-cni-intergration-template.yaml | Updates the AzureCLI task version and changes Cilium variable names for installation steps. |
| .pipelines/cni/lsg/kernel-upgrade-template.yaml | Upgrades the AzureCLI task version. |
| .pipelines/cni/load-test-templates/**/*.yaml | Upgrades the AzureCLI task version and adds region parameters where applicable. |
| .pipelines/cni/cilium/**/*.yaml | Updates task versions, variable naming from CILIUM_VERSION_TAG to CILIUM_VERSION_TAG_V1_5, and introduces conditional region settings. |
| .golangci.yml, .github/workflows/**/*.yaml | Bumps Go version requirements and updates tool versions for linting and code analysis. |
Files not reviewed (2)
- .devcontainer/Dockerfile: Language not supported
- .devcontainer/devcontainer.json: Language not supported
Comments suppressed due to low confidence (2)
.pipelines/cni/lsg/lsg-cni-intergration-template.yaml:0
- The file name 'lsg-cni-intergration-template.yaml' appears to contain a spelling error; consider renaming it to 'lsg-cni-integration-template.yaml' for improved clarity.
lsg-cni-intergration-template.yaml
.pipelines/cni/cilium/cilium-overlay-load-test-template.yaml:44
- [nitpick] Consider using a consistent naming convention for region variables across templates (e.g., using 'region' instead of 'location') to avoid confusion in pipeline configurations.
region: $(location)
huntergregory
previously approved these changes
Apr 29, 2025
rayaisaiah
force-pushed
the
isaiahraya/removeHostUsersNPMV1.5
branch
from
3c3c4ee to
b184664
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Removes the
hostUsers: falsesetting in the NPM daemonset. Reverts from changes #2589Issue Fixed:
From https://kubernetes.io/docs/concepts/workloads/pods/user-namespaces/#limitations
When using a user namespace for the pod, it is disallowed to use other host namespaces. In particular, if you set
hostUsers: falsethen you are not allowed to set any of:Requirements:
Notes: