chore: update tolerations in cilium operator manifests, makefile fix #3640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the toleration settings in the cilium operator deployment manifests to align with the expectations of AKS charts and fixes a variable substitution error in the Makefile for bringing up the overlay Cilium cluster.
- Updated tolerations in deployment manifests for cilium-operator in v1.16, v1.14, and v1.13.
- Fixed variable substitution in hack/aks/Makefile for the load-balancer outbound IPs.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/integration/manifests/cilium/v1.16/cilium-operator/templates/deployment.yaml | Adds two additional tolerations entries. |
| test/integration/manifests/cilium/v1.14/cilium-operator/templates/deployment.yaml | Adds two additional tolerations entries. |
| test/integration/manifests/cilium/v1.13/cilium-operator/templates/deployment.yaml | Adds two additional tolerations entries. |
| hack/aks/Makefile | Corrects the variable substitution for PUBLIC_IPv4 in the overlay-cilium-up target. |
Contributor
Author
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jpayne3506
approved these changes
May 8, 2025
vipul-21
reviewed
May 8, 2025
test/integration/manifests/cilium/v1.13/cilium-operator/templates/deployment.yaml
Show resolved
Hide resolved
vipul-21
approved these changes
May 8, 2025
sivakami-projects
pushed a commit
that referenced
this pull request
Oct 23, 2025
…3640) chore: update tolerations test impact in restart test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
update operator tolerations to match AKS charts
small makefile fix in overlay-cilium-up
Issue Fixed:
Requirements:
Notes: