change apipa endpoint gateway back to .1 #3653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR reverts the APIPA endpoint gateway change on Windows to use the loopback adapter IP, ensuring that the gateway value is restored to .1 to resolve the NC-to-host connectivity issue.
- Removed the assignment of hostApipaIP using localIPConfiguration.GatewayIPAddress.
- Updated the hcnRoute to use hnsLoopbackAdapterIPAddress for the NextHop field.
Comments suppressed due to low confidence (2)
cns/hnsclient/hnsclient_windows.go:509
- The removal of hostApipaIP assignment is acceptable if hnsLoopbackAdapterIPAddress consistently represents the intended '.1' gateway. Please verify that hnsLoopbackAdapterIPAddress is defined and maintained correctly across the codebase.
hostApipaIP := localIPConfiguration.GatewayIPAddress
cns/hnsclient/hnsclient_windows.go:529
- Ensure that hnsLoopbackAdapterIPAddress reliably holds the correct gateway IP (.1) as mandated by the revert. Confirm this change aligns with the overall host container networking requirements.
NextHop: hnsLoopbackAdapterIPAddress,
msvik
reviewed
May 12, 2025
Contributor
Author
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
msvik
approved these changes
May 13, 2025
nairashu
approved these changes
May 13, 2025
QxBytes
approved these changes
May 14, 2025
Contributor
QxBytes
left a comment
QxBytes
left a comment
There was a problem hiding this comment.
confirmed w/ zetao that new endpoints have "endpoint gateway addr" as .1 and existing endpoints can retain their "endpoint gateway addr" as .2 without issue
sivakami-projects
pushed a commit
that referenced
this pull request
Oct 23, 2025
* change apipa endpoint gateway back to .1 * lint fix * add comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
revert the apipa endpoint gw change to .1 to resolve the nc to host connection issue in Linux contianer. This does not impact the initial change for changing the apipa network gw and loop adapter defualt gw from .1 to .2 on host.
Issue Fixed:
Requirements:
Notes:
This fix already been verified by updating the legacy runner cns with this fix for both windows and linux containers.