[ci] fix: make variable assignment #3655
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the issue with reassigning make variable values by introducing a new variable (LTS_ARGS) to handle the LTS arguments during cluster creation.
- Replaces LTS with LTS_ARGS in variable assignment and command invocations
- Updates command-line calls to use LTS_ARGS for consistency
camrynl
previously approved these changes
May 13, 2025
Contributor
Author
|
Confirmed working as intended with #3667 checks |
camrynl
approved these changes
May 15, 2025
vipul-21
approved these changes
May 15, 2025
Contributor
Author
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
sivakami-projects
pushed a commit
that referenced
this pull request
Oct 23, 2025
* fix: make variable assignment * chore: copilot suggestion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Cannot reassign make variable values. Leverage
LTSas a "boolean" value and setLTS_ARGSappropriately for cluster creation.Issue Fixed:
Requirements:
Notes: