Skip to content

Conversation

@jpayne3506
Copy link
Contributor

@jpayne3506 jpayne3506 commented Jun 12, 2025

Reason for Change:

Issue Fixed:

Requirements:

Notes:

Copilot AI review requested due to automatic review settings June 12, 2025 02:43
@jpayne3506 jpayne3506 added the ci Infra or tooling. label Jun 12, 2025
@jpayne3506 jpayne3506 requested a review from a team as a code owner June 12, 2025 02:43
@jpayne3506 jpayne3506 added the needs-backport Change needs to be backported to previous release trains label Jun 12, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the CI process by leveraging renderkit on the CNI/CNS pipeline Dockerfiles. The changes add new environment variables and render commands in the Makefile for pipeline-specific Dockerfile generation, update CNS Dockerfile templates to incorporate new render variables and base image changes, and introduce corresponding CNI Dockerfile templates and generated files.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
build/images.mk Adds new PIPE-PATH, SRC_PIPE, and DEST-PIPE variables and a new render command
.pipelines/build/dockerfiles/cns.Dockerfile.tmpl Updates template comments and render variable references
.pipelines/build/dockerfiles/cns.Dockerfile Updates autogenerated Dockerfile with revised base images and Windows alias casing
.pipelines/build/dockerfiles/cni.Dockerfile.tmpl Introduces a new template for CNI with basic Windows and Linux configurations
.pipelines/build/dockerfiles/cni.Dockerfile Adds the generated Dockerfile for CNI with updated reference to the new template
Comments suppressed due to low confidence (2)

build/images.mk:18

  • Consider renaming the variable 'PIPE-PATH' to use underscores (e.g., PIPE_PATH) for clarity and to avoid potential issues with hyphenated variable names in Makefiles.
export PIPE-PATH	?= .pipelines/build/dockerfiles

build/images.mk:20

  • Consider renaming 'DEST-PIPE' to use underscores (e.g., DEST_PIPE) to improve readability and consistency with typical Makefile naming conventions.
export DEST-PIPE	?= ${PIPE-PATH}/${PATH}.Dockerfile

@jpayne3506
Copy link
Contributor Author

Closing in favor of #3606

@jpayne3506 jpayne3506 closed this Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Infra or tooling. needs-backport Change needs to be backported to previous release trains

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants