-
Notifications
You must be signed in to change notification settings - Fork 260
fix: [NPM] [Backport] Update Ubuntu Base Image to 24.04 #3743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rayaisaiah
merged 1 commit into
release/v1.6
from
isaiahraya/update-npm-ubuntu-24.04-release/v1.6
Jun 18, 2025
Merged
fix: [NPM] [Backport] Update Ubuntu Base Image to 24.04 #3743
rayaisaiah
merged 1 commit into
release/v1.6
from
isaiahraya/update-npm-ubuntu-24.04-release/v1.6
Jun 18, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bump ubuntu to 24.04
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR backports updates to Ubuntu base image and manually pins certain Ubuntu packages to address known vulnerabilities.
- Upgrade Ubuntu base image from 20.04 to 24.04.
- Manually update libsystemd0 and libudev1 versions to address CVE-2025-4598.
Comments suppressed due to low confidence (2)
npm/linux.Dockerfile:9
- Consider adding an inline comment explaining the upgrade to Ubuntu 24.04 due to Ubuntu 20.04 reaching EOL, to help future maintainers understand the reason behind this change.
FROM mcr.microsoft.com/mirror/docker/library/ubuntu:24.04 as linux
npm/linux.Dockerfile:11
- Please add a brief comment explaining the manual version pinning for libsystemd0 and libudev1 (addressing CVE-2025-4598), which will enhance clarity for future reviews.
RUN apt-get update && apt-get install -y libsystemd0=255.4-1ubuntu8.8 libudev1=255.4-1ubuntu8.8 iptables ipset ca-certificates && apt-get autoremove -y && apt-get clean
Contributor
Author
|
/azp run Azure Container Networking PR |
Contributor
Author
|
/azp run NPM Conformance Tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run NPM Scale Test |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
vakalapa
approved these changes
Jun 18, 2025
4 tasks
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Backports #3741 from master branch.
Bumps the NPM Ubuntu base image version from
20.04to24.04as20.04is EOL and no longer supported (https://ubuntu.com/blog/ubuntu-20-04-lts-end-of-life-standard-support-is-coming-to-an-end-heres-how-to-prepare).Manually updates the Ubuntu packages
libsystemd0andlibudev1to255.4-1ubuntu8.8or elseCVE-2025-4598is present in the image (Will revert later when base image updates packages to resolve the vulnerability):Trivy scan of NPM linux with changes to dockerfile (with manual package updates):
Tests Ran:
Issue Fixed:
Requirements:
Notes:
Releasing from
release/v1.6branch instead ofrelease/v1.5due to Ubuntu base image update as well as v1.5 will be not be supported soon (due to k8s dependencies not matching with our offerings as it is tied to 1.27-1.29).