ci: add azure ipam and azure ip masq merger uts to pipeline #3756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the CI pipeline to include unit tests for both the azure ipam and azure ip masq merger modules, ensuring that code coverage is combined across modules.
- Updated the workspace in the Makefile to include the azure-ip-masq-merger module.
- Modified test targets in the Makefile to run unit tests with race detection and coverage reports for both modules.
- Enhanced the pipeline YAML to combine coverage outputs and set up the workspace before running tests, and updated CODEOWNERS for the new module.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Makefile | Updated workspace and test targets to integrate new modules. |
| .pipelines/templates/run-unit-tests.yaml | Combined multiple module coverage and invoked workspace setup. |
| .github/CODEOWNERS | Added code ownership for the azure-ip-masq-merger module. |
Comments suppressed due to low confidence (1)
.pipelines/templates/run-unit-tests.yaml:29
- [nitpick] It would be beneficial to include additional context in the comment explaining why 'tail -q -n +2' is used to combine the coverage files, ensuring clarity for future maintainers.
# combine coverage from multiple modules
Contributor
Author
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jpayne3506
reviewed
Jun 25, 2025
jpayne3506
approved these changes
Jun 25, 2025
rbtr
approved these changes
Jun 25, 2025
NihaNallappagari
pushed a commit
to NihaNallappagari/azure-container-networking
that referenced
this pull request
Sep 4, 2025
* add azure-ip-masq-merger to go work and include other modules in uts * modify CODEOWNERS * add individual module coverage
sivakami-projects
pushed a commit
that referenced
this pull request
Oct 23, 2025
* add azure-ip-masq-merger to go work and include other modules in uts * modify CODEOWNERS * add individual module coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates codeowners and adds uts for these go modules to the pr pipeline, combining code coverage as necessary. Previously, azure ipam and azure ip masq merger uts weren't included in make test-all because they were in different modules from the root module. Running make workspace before running the coverage allows us to include these numbers in the overall code coverage.
Reason for Change:
See above.
Issue Fixed:
Requirements:
Notes: