[backport] - (#3776)(#3768) perf: update error message for MTPNC not found and not ready in CNS #3775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the network readiness error message so that kubelet will recognize it and retry faster, aligning with upstream expectations.
- Prefixes the existing mtpnc-not-ready error with “network is not ready”
- Adds an inline comment linking to the kubelet source that checks for this string
- (Unit tests and documentation updates included in the cherry-picked PR)
Comments suppressed due to low confidence (2)
cns/middlewares/k8sSwiftV2.go:22
- Ensure there is a unit test that specifically asserts this error message starts with "network is not ready", so kubelet will detect and retry as intended.
errMTPNCNotReady = errors.New("network is not ready - mtpnc is not ready")
cns/middlewares/k8sSwiftV2.go:22
- [nitpick] The variable name
errMTPNCNotReadynow covers network readiness; consider renaming it toerrNetworkNotReadyor similar to better reflect its scope.
errMTPNCNotReady = errors.New("network is not ready - mtpnc is not ready")
Contributor
|
@isaac-dasan I can see that this PR is a cherry-pick and the diff is tiny, but we have been talking about having all changes being under UT coverage, could we please add one? One approach that works pretty well for all fixes is to add an assertion that fails without your fix, but passes with the fix. |
santhoshmprabhu
previously approved these changes
Jul 4, 2025
Contributor
santhoshmprabhu
left a comment
santhoshmprabhu
left a comment
There was a problem hiding this comment.
UT will be added when we cherry pick #3776 to 1.6.
miguelgoms
previously approved these changes
Jul 8, 2025
isaac-dasan
dismissed stale reviews from miguelgoms and santhoshmprabhu
via
00d66ee
Member
Author
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
update network error msg to match kubelet expectations Signed-off-by: GitHub <[email protected]>
…3776) squash commit to prevent github CLA issue Signed-off-by: GitHub <[email protected]>
isaac-dasan
force-pushed
the
isaac/1-6cherrypick/mtpncerrormessage
branch
from
00d66ee to
6da6ad6
Compare
isaac-dasan
changed the title
isaac-dasan
changed the title
rejain456
approved these changes
Jul 11, 2025
Member
Author
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ravisraju
approved these changes
Jul 11, 2025
rbtr
approved these changes
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update network error msg to match kubelet expectations
cherry pick from master of this
Requirements:
Notes: