Skip to content

Conversation

@jpayne3506
Copy link
Contributor

Reason for Change:

See #3791

Issue Fixed:

Requirements:

Notes:

@jpayne3506 jpayne3506 self-assigned this Jul 10, 2025
Copilot AI review requested due to automatic review settings July 10, 2025 17:03
@jpayne3506 jpayne3506 added fix Fixes something. ci Infra or tooling. labels Jul 10, 2025
@jpayne3506 jpayne3506 requested a review from a team as a code owner July 10, 2025 17:03
@jpayne3506 jpayne3506 added the release/1.6 Change affects 1.6 release train label Jul 10, 2025
@jpayne3506
Copy link
Contributor Author

/azp run Azure Container Networking PR

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refines the unit test pipeline to aggregate coverage results across modules and only run the code coverage check for PRs coming through the merge queue.

  • Combine multiple coverage-*.out files into a single report before publishing.
  • Add a conditional to run the code_coverage stage only when the branch name matches the merge-queue pattern.
  • Initialize a Go workspace (make workspace) so coverage tooling includes all modules.
Comments suppressed due to low confidence (3)

.pipelines/templates/run-unit-tests.yaml:67

  • The conditional hook is misaligned under stages. The - ${{ if … }}: line should be indented according to Azure Pipelines template syntax so that the code_coverage stage is correctly gated and parsed.
  - ${{ if contains(variables['Build.SourceBranch'], 'master/pr') }}:

.pipelines/templates/run-unit-tests.yaml:67

  • [nitpick] Using a hard-coded branch pattern 'master/pr' can be brittle. Consider parameterizing this pattern in your pipeline variables or templates for easier updates and reuse.
  - ${{ if contains(variables['Build.SourceBranch'], 'master/pr') }}:

.pipelines/templates/run-unit-tests.yaml:30

  • If no files match coverage-*.out, the tail command will fail and break the pipeline. Consider checking for file existence or using a glob-safe approach to avoid errors when coverage files are absent.
              (echo "mode: atomic"; tail -q -n +2 coverage-*.out) > coverage.cover

@azure-pipelines
Copy link

Azure Pipelines failed to run 1 pipeline(s).

@jpayne3506 jpayne3506 force-pushed the jpayne3506/bp-3791 branch from 41235cb to 1eb12b4 Compare July 10, 2025 17:05
@jpayne3506
Copy link
Contributor Author

/azp run Azure Container Networking PR

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

rayaisaiah
rayaisaiah previously approved these changes Jul 10, 2025
@rbtr rbtr enabled auto-merge (squash) July 10, 2025 17:49
@jpayne3506 jpayne3506 force-pushed the jpayne3506/bp-3791 branch from 1eb12b4 to 9f2610e Compare July 10, 2025 18:02
@jpayne3506 jpayne3506 changed the title [backport] #3791 ci: only check for code coverage [backport] #3791 ci: only check for code coverage at merge, not release Jul 10, 2025
@jpayne3506
Copy link
Contributor Author

/azp run Azure Container Networking PR

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rbtr rbtr merged commit b5d7d2b into release/v1.6 Jul 10, 2025
10 of 15 checks passed
@rbtr rbtr deleted the jpayne3506/bp-3791 branch July 10, 2025 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Infra or tooling. fix Fixes something. release/1.6 Change affects 1.6 release train

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants