backport: feat: cns logger v2 [2/2] (#3438) #3897
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: add migration shim and config for v2 logger Signed-off-by: Evan Baker <[email protected] * add logger config to CNS config Signed-off-by: Evan Baker <[email protected]> * map telemetry metadata fields and compose logger Signed-off-by: Evan Baker <[email protected]> --------- Signed-off-by: Evan Baker <[email protected] Signed-off-by: Evan Baker <[email protected]>
rbtr
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements a backport of CNS logger v2 to the 1.6 release, introducing a new Zap-based logging system alongside the existing v1 logger. The change enables optional migration to structured logging with support for multiple output targets including Application Insights, file, stdout, and ETW.
- Adds a complete v2 logger package built on Zap with support for multiple output cores
- Implements a shim layer to maintain backward compatibility with the existing v1 logger interface
- Integrates the new logger into CNS main service with conditional enablement via configuration
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| cns/service/main.go | Integrates v2 logger initialization and conditionally replaces global logger |
| cns/logger/v2/*.go | New v2 logger implementation with Zap core, configuration, and platform-specific support |
| cns/logger/log.go | Adds deprecation warnings and interface abstraction for logger compatibility |
| cns/logger/cnslogger.go | Refactors v1 logger to implement new interface for backward compatibility |
| cns/configuration/configuration.go | Adds EnableLoggerV2 flag and v2 logger configuration to CNS config |
| aitelemetry/telemetrywrapper*.go | Centralizes metadata file path configuration across platforms |
Collaborator
Author
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
paulyufan2
approved these changes
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport loggerv2 to 1.6 release