Skip to content

Conversation

@rayaisaiah
Copy link
Contributor

Reason for Change:
Reverts manual package installations made to the NPM Linux dockerfile for libsystemd0, libudev1, libpam-modules, libpam-modules-bin, libpam-runtime, libpam0g. These changes were made as NPM base image (Ubuntu) did not have the updated packages installed which lead to CVEs on the base image. Ubuntu has since been patched to have the CVEs resolved so there is no need to manually install the packages at a specific version.

Issue Fixed:

Requirements:

Notes:

Copilot AI review requested due to automatic review settings August 13, 2025 17:57
@rayaisaiah rayaisaiah added the npm Related to NPM. label Aug 13, 2025
@rayaisaiah rayaisaiah requested a review from a team as a code owner August 13, 2025 17:57
@rayaisaiah rayaisaiah requested a review from matmerr August 13, 2025 17:57
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reverts the manual installation of specific versions of system packages (libsystemd0, libudev1, libpam-modules, libpam-modules-bin, libpam-runtime, libpam0g) from the NPM Linux Dockerfile. The manual installations were previously added to address CVEs in the Ubuntu base image, but are no longer needed since Ubuntu has been patched to resolve these security vulnerabilities.

  • Removes explicit version pinning for 6 system packages that were manually installed
  • Simplifies the RUN command to only install essential packages (iptables, ipset, ca-certificates)
  • Reduces maintenance overhead by relying on the updated Ubuntu base image packages

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@rayaisaiah
Copy link
Contributor Author

/azp run Azure Container Networking PR, NPM Scale Test, NPM Conformance Tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@rayaisaiah
Copy link
Contributor Author

@rayaisaiah rayaisaiah added this pull request to the merge queue Aug 13, 2025
Merged via the queue into master with commit 969e8e0 Aug 13, 2025
33 of 34 checks passed
@rayaisaiah rayaisaiah deleted the isaiahraya/npm-remove-package-installations branch August 13, 2025 22:55
NihaNallappagari pushed a commit to NihaNallappagari/azure-container-networking that referenced this pull request Sep 4, 2025
…systemd0, libudev1, libpam-modules, libpam-modules-bin, libpam-runtime, libpam0g) (Azure#3928)

removed manual package installations
sivakami-projects pushed a commit that referenced this pull request Oct 23, 2025
…systemd0, libudev1, libpam-modules, libpam-modules-bin, libpam-runtime, libpam0g) (#3928)

removed manual package installations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

linux npm Related to NPM.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants