[chore]Fix kubenetes related package upgrade #3952
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes Kubernetes-related package upgrade issues by updating dependency versions and correcting an error formatting issue in test utilities.
- Update Go version from 1.23.2 to 1.24.6
- Upgrade multiple Kubernetes dependencies (k8s.io/api, k8s.io/apimachinery, k8s.io/client-go, k8s.io/kubernetes) from 0.30.x to 0.33.x versions
- Fix error message formatting in deployment deletion test utility
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| go.mod | Updates Go version and numerous Kubernetes and related dependencies to newer versions |
| test/internal/kubernetes/utils.go | Fixes error message formatting by removing redundant fmt.Sprintf wrapper |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
Author
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
no need to do this now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
The PR is to fix kubernetes, client-go, kubectl and apiservermachine dep package upgrades which kept failing
Issue Fixed:
Requirements:
Notes: