Skip to content

Conversation

@jpayne3506
Copy link
Contributor

Reason for Change:

Missed coverage for ipv6 related kernel changes.

Issue Fixed:

Requirements:

Notes:
See #3993

@jpayne3506 jpayne3506 self-assigned this Sep 4, 2025
@jpayne3506 jpayne3506 added the ci Infra or tooling. label Sep 4, 2025
Copilot AI review requested due to automatic review settings September 4, 2025 17:59
@jpayne3506 jpayne3506 requested a review from a team as a code owner September 4, 2025 17:59
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds IPv6 dualstack coverage to the LSG-CNI pipeline by introducing new test configurations and conditional logic to handle dualstack deployments. The changes address missed coverage for IPv6-related kernel changes in the Azure Container Networking project.

  • Adds two new dualstack test configurations (linux_overlay_ds and cilium_overlay_ds)
  • Implements conditional deployment logic to handle dualstack vs standard overlay configurations
  • Updates cleanup procedures to include dualstack cluster deletion

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
.pipelines/cni/lsg/pipeline.yaml Adds dualstack test stages and corresponding cleanup jobs, updates commitID generation
.pipelines/cni/lsg/lsg-cni-intergration-template.yaml Implements conditional logic for dualstack cluster creation and CNI installation
Comments suppressed due to low confidence (1)

.pipelines/cni/lsg/lsg-cni-intergration-template.yaml:1

  • Template filename contains a typo: 'intergration' should be 'integration'.
parameters:

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@jpayne3506 jpayne3506 force-pushed the jpayne3506/lsg-dualstack branch 2 times, most recently from 70e68db to e34e171 Compare September 5, 2025 16:18
@jpayne3506 jpayne3506 force-pushed the jpayne3506/lsg-dualstack branch from e34e171 to 7335b3d Compare September 5, 2025 16:18
@jpayne3506
Copy link
Contributor Author

/azp run Azure Container Networking PR

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

paulyufan2
paulyufan2 previously approved these changes Sep 5, 2025
Copy link
Contributor

@paulyufan2 paulyufan2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@paulyufan2
Copy link
Contributor

/azp run Azure Container Networking PR

@paulyufan2 paulyufan2 enabled auto-merge September 6, 2025 01:42
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@paulyufan2 paulyufan2 added this pull request to the merge queue Sep 6, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 6, 2025
@paulyufan2 paulyufan2 added this pull request to the merge queue Sep 8, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 8, 2025
@jpayne3506 jpayne3506 added this pull request to the merge queue Sep 8, 2025
Merged via the queue into master with commit 8100de6 Sep 8, 2025
15 of 16 checks passed
@jpayne3506 jpayne3506 deleted the jpayne3506/lsg-dualstack branch September 8, 2025 19:19
sivakami-projects pushed a commit that referenced this pull request Oct 23, 2025
* ci: add dualstack coverage to LSG-CNI pipeline

* chore: cleanup typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Infra or tooling.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants