-
Notifications
You must be signed in to change notification settings - Fork 259
ci: add dualstack coverage to LSG-CNI pipeline #4001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds IPv6 dualstack coverage to the LSG-CNI pipeline by introducing new test configurations and conditional logic to handle dualstack deployments. The changes address missed coverage for IPv6-related kernel changes in the Azure Container Networking project.
- Adds two new dualstack test configurations (linux_overlay_ds and cilium_overlay_ds)
- Implements conditional deployment logic to handle dualstack vs standard overlay configurations
- Updates cleanup procedures to include dualstack cluster deletion
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| .pipelines/cni/lsg/pipeline.yaml | Adds dualstack test stages and corresponding cleanup jobs, updates commitID generation |
| .pipelines/cni/lsg/lsg-cni-intergration-template.yaml | Implements conditional logic for dualstack cluster creation and CNI installation |
Comments suppressed due to low confidence (1)
.pipelines/cni/lsg/lsg-cni-intergration-template.yaml:1
- Template filename contains a typo: 'intergration' should be 'integration'.
parameters:
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
70e68db to
e34e171
Compare
e34e171 to
7335b3d
Compare
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
paulyufan2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
* ci: add dualstack coverage to LSG-CNI pipeline * chore: cleanup typo
Reason for Change:
Missed coverage for ipv6 related kernel changes.
Issue Fixed:
Requirements:
Notes:
See #3993