Skip to content

feat: Populate homeAZ on nodeInfo CRD #4009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 24, 2025
Merged

feat: Populate homeAZ on nodeInfo CRD #4009

merged 3 commits into from
Sep 24, 2025

Conversation

@carlotaarvela
Copy link
Contributor

@carlotaarvela carlotaarvela commented Sep 5, 2025 •
edited
Loading

Reason for Change:
Populate homeAZ on nodeInfo

Issue Fixed:

Requirements:

Notes:

@carlotaarvela
Copy link
Contributor Author

carlotaarvela commented Sep 10, 2025

/azp run Azure Container Networking PR

@azure-pipelines
Copy link

azure-pipelines bot commented Sep 10, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@carlotaarvela carlotaarvela marked this pull request as ready for review September 10, 2025 17:18
Copilot AI review requested due to automatic review settings September 10, 2025 17:18
@carlotaarvela carlotaarvela requested review from a team as code owners September 10, 2025 17:18
Copilot AI reviewed Sep 10, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the NodeInfo Custom Resource Definition (CRD) by adding HomeAZ (Availability Zone) information alongside the existing VM unique ID. The changes enable CNS to retrieve the HomeAZ from the CNS client and populate it in the NodeInfo CRD for better node management and placement decisions.

  • Adds HomeAZ field population to the NodeInfo CRD creation/update functionality
  • Retrieves HomeAZ information from CNS client and formats it as "AZ%02d"
  • Includes comprehensive test coverage for the new functionality with mocked dependencies
  • Updates Docker base image versions across multiple Dockerfiles

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
cns/service/main.go Adds CNS client integration to retrieve and populate HomeAZ in NodeInfo CRD
cns/service/main_test.go Comprehensive test for NodeInfo CRD creation with HomeAZ validation using mock servers
cns/Dockerfile Updates Azure Linux base image versions
cni/Dockerfile Updates Azure Linux base image versions
.pipelines/build/dockerfiles/cns.Dockerfile Updates Azure Linux base image versions

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@carlotaarvela
Copy link
Contributor Author

carlotaarvela commented Sep 11, 2025

/azp run Azure Container Networking PR

@azure-pipelines
Copy link

azure-pipelines bot commented Sep 11, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@carlotaarvela carlotaarvela force-pushed the carlota/homeaz-on-nodeinfocrd branch from ea246be to aab7c06 Compare September 16, 2025 10:53
@carlotaarvela carlotaarvela changed the title Populate homeAZ on nodeInfo CRD feat: Populate homeAZ on nodeInfo CRD Sep 16, 2025
@carlotaarvela carlotaarvela added cns Related to CNS. AZR AZR related PR labels Sep 16, 2025
Copilot AI reviewed Sep 16, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@carlotaarvela carlotaarvela force-pushed the carlota/homeaz-on-nodeinfocrd branch from aab7c06 to 4b8cd08 Compare September 16, 2025 11:00
Copilot AI reviewed Sep 16, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@carlotaarvela
Copy link
Contributor Author

carlotaarvela commented Sep 16, 2025

/azp run Azure Container Networking PR

@azure-pipelines
Copy link

azure-pipelines bot commented Sep 16, 2025

Azure Pipelines successfully started running 1 pipeline(s).

csfmomo
csfmomo reviewed Sep 22, 2025
View reviewed changes
@carlotaarvela
Copy link
Contributor Author

carlotaarvela commented Sep 22, 2025

/azp run Azure Container Networking PR

@carlotaarvela carlotaarvela force-pushed the carlota/homeaz-on-nodeinfocrd branch from 8a94176 to 3abc28f Compare September 22, 2025 15:37
@Azure Azure deleted a comment from azure-pipelines bot Sep 22, 2025
@carlotaarvela
Copy link
Contributor Author

carlotaarvela commented Sep 22, 2025

/azp run Azure Container Networking PR

@azure-pipelines
Copy link

azure-pipelines bot commented Sep 22, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@carlotaarvela carlotaarvela force-pushed the carlota/homeaz-on-nodeinfocrd branch from 3abc28f to ef6d7ab Compare September 22, 2025 21:38
csfmomo
csfmomo reviewed Sep 23, 2025
View reviewed changes
csfmomo
csfmomo previously approved these changes Sep 23, 2025
View reviewed changes
@carlotaarvela
Copy link
Contributor Author

carlotaarvela commented Sep 23, 2025

/azp run Azure Container Networking PR

@azure-pipelines
Copy link

azure-pipelines bot commented Sep 23, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@carlotaarvela carlotaarvela added this pull request to the merge queue Sep 24, 2025
Merged via the queue into master with commit d66b2f9 Sep 24, 2025
12 checks passed
@carlotaarvela carlotaarvela deleted the carlota/homeaz-on-nodeinfocrd branch September 24, 2025 19:06
carlotaarvela added a commit that referenced this pull request Oct 6, 2025
@carlotaarvela
Revert "feat: Populate homeAZ on nodeInfo CRD (#4009)"
1be1d18 
This reverts commit d66b2f9.
github-merge-queue bot pushed a commit that referenced this pull request Oct 8, 2025
@carlotaarvela
revert: homeaz on nodeinfocrd (#4065)
93fee76 
* Revert "feat: Populate homeAZ on nodeInfo CRD (#4009)"

This reverts commit d66b2f9.

* Update images
sivakami-projects pushed a commit that referenced this pull request Oct 23, 2025
@carlotaarvela
feat: Populate homeAZ on nodeInfo CRD (#4009)
44e19f0 
* feat: Populate HomeAZ on nodeInfo CRD

* PR comments

* Lint
sivakami-projects pushed a commit that referenced this pull request Oct 23, 2025
@carlotaarvela
revert: homeaz on nodeinfocrd (#4065)
41af225 
* Revert "feat: Populate homeAZ on nodeInfo CRD (#4009)"

This reverts commit d66b2f9.

* Update images
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@rbtr rbtr rbtr approved these changes

@csfmomo csfmomo csfmomo approved these changes

@ibezrukavyi ibezrukavyi ibezrukavyi approved these changes

@vipul-21 vipul-21 Awaiting requested review from vipul-21 vipul-21 is a code owner automatically assigned from Azure/acn-cni-reviewers

@tamilmani1989 tamilmani1989 Awaiting requested review from tamilmani1989 tamilmani1989 is a code owner automatically assigned from Azure/acn-cns-reviewers

@thatmattlong thatmattlong Awaiting requested review from thatmattlong

Assignees

No one assigned

Labels

AZR AZR related PR cns Related to CNS.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@carlotaarvela @rbtr @csfmomo @ibezrukavyi