Conversation
the images should only be required during the e2e stage after cluster creation the e2e stage is already dependent on publish multiarch manifests, which is already dependent on build images; thus, all e2e stages are implictly dependent on the build image stage success
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR reorganizes the CI pipeline stages to improve build efficiency by restructuring dependencies and parallelizing operations. The changes aim to speed up pipeline execution by allowing image builds to start during unit tests and removing unnecessary dependencies between stages.
- Removed dependency on test stage for build and containerize stages to allow parallel execution
- Created a separate
publish_npmstage for NPM multiarch manifest creation - Changed E2E test dependencies from "containerize" to "test" to enable cluster creation without waiting for image builds
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
jpayne3506
approved these changes
Oct 3, 2025
Contributor
jpayne3506
left a comment
There was a problem hiding this comment.
Moving NPM manifest stage to its own stage can potentially save us 20-30 minutes. Thank you for this change @QxBytes
vipul-21
approved these changes
Oct 3, 2025
sivakami-projects
pushed a commit
that referenced
this pull request
Oct 23, 2025
* shortcircuit ut * test multi dependency * split npm manifest out * remove dependency of create cluster on build images in acn pr pipeline the images should only be required during the e2e stage after cluster creation the e2e stage is already dependent on publish multiarch manifests, which is already dependent on build images; thus, all e2e stages are implictly dependent on the build image stage success
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Start building images during the unit test stage, remove cluster create dependency on image build, move npm manifest creation to new stage. Aiming to speed up pipeline runs.
Issue Fixed:
See above
Requirements:
Notes:
Latest: https://msazure.visualstudio.com/One/_build/results?buildId=139113170
POC: https://msazure.visualstudio.com/One/_build/results?buildId=139103901