fix: cilium nightly pipeline set boringcrypto arg in build #4063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the Cilium nightly pipeline by adding boringcrypto configuration to unblock operator image builds. The change specifically modifies the build process to set the GOEXPERIMENT argument to enable boringcrypto for Microsoft Go when building the docker-operator-generic-image.
- Adds conditional logic to patch Dockerfile for operator image builds
- Sets GOEXPERIMENT=boringcrypto as build argument and environment variable
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
jpayne3506
approved these changes
Oct 3, 2025
vipul-21
approved these changes
Oct 3, 2025
Contributor
vipul-21
left a comment
vipul-21
left a comment
There was a problem hiding this comment.
Do we need this ciliumprivate too ?
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
sivakami-projects
pushed a commit
that referenced
this pull request
Oct 23, 2025
* skip goimg override * test build go 1.25.0 * test go 1.25.0-1 * set nosystemcrypto * test * test * set cgo * try patching dockerfile * insert patch differt loc * update env * update env 2 * update env 3 * set condtion for operator * set condtion for operator fix * set condtion for operator fix 2 * set condtion for operator fix 3 * add back build args * test cgo 0 * set systemcrypto * set systemcrypto test * set goexperiment for microsoft img only * replace nosystemcrypto with boringcrypto * cleanup docker no cache * cleanup * test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
unblock operator image build by setting GOEXPERIMENT arg to boringcrypto
Issue Fixed:
Requirements:
Notes: