-
Notifications
You must be signed in to change notification settings - Fork 260
ci: add cilium ebpf e2e overlay and podsubnet test #4073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds an E2E test stage for overlay Cilium eBPF host routing to the CI pipeline, along with reorganizing pipeline infrastructure and introducing new Makefile targets for cluster deployment.
- Adds new eBPF overlay Cilium test configuration with required Kubernetes manifests
- Introduces pipeline infrastructure for testing overlay Cilium with eBPF dataplane
- Refactors Makefile structure to support eBPF deployment patterns
Reviewed Changes
Copilot reviewed 15 out of 16 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/validate/linux_validate.go | Adds container name specification for cilium agent validation |
| test/integration/manifests/cilium/v1.17/ebpf/overlay/static/* | New static configuration files for eBPF overlay Cilium deployment |
| test/integration/manifests/cilium/v1.17/ebpf/overlay/cilium.yaml | Main Cilium DaemonSet configuration with eBPF and overlay networking |
| test/integration/manifests/cilium/v1.17/ebpf/common/* | Common eBPF configuration files including RBAC and network policies |
| hack/aks/deploy.mk | New Makefile with deployment targets for eBPF Cilium configurations |
| hack/aks/Makefile | Updated with eBPF cluster creation and common deployment infrastructure |
| .pipelines/templates/* | New pipeline templates for environment setup and cluster creation |
| .pipelines/singletenancy/cilium-overlay-ebpf/* | Complete pipeline configuration for eBPF overlay testing |
| .pipelines/pipeline.yaml | Integration of new eBPF test stage into main pipeline |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
.pipelines/singletenancy/cilium-overlay-ebpf/cilium-overlay-e2e-step-template.yaml
Show resolved
Hide resolved
|
can we add e2e for pod subnet too? |
d9e5fd5 to
1b3164c
Compare
1b3164c to
8211742
Compare
the only difference between the two is overlay has check that deletes the cilium test namespace and validates the state-- otherwise the cilium tests template is identical previous commit passed
10091a0 to
f1f9e5a
Compare
f1f9e5a to
0926778
Compare
santhoshmprabhu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked with Alexander about a couple of concerns, we'll have a follow up PR for 1 more test case.
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
* add initial ebpf overlay modifications * hardcode values for testing * add depends to delete * make ebpf use cilium v1.17 * hardcode cluster name for testing * export makefile variables * add container for cilium command * add default os sku without the default value for osSKU, it is set to the empty string which is not "undefined", and so the the makefile's ?= default value is not used either, leading to the os SKU in the makefile being "" * move pod cidr to variable * add ccnp to deploys to block wireserver * amend ccnp to not block imds yet * Revert "hardcode cluster name for testing" This reverts commit 5945c63. * Revert "hardcode values for testing" This reverts commit f3ddf71. * rename targets and files * apply crd before custom resource * test ebpf with test iptables monitor and merger images * begin templating- previous commit passed * remove hubble and nightly copied code * remove unused vars and rename target (noop) * test ebpf podsubnet * reuse existing template the only difference between the two is overlay has check that deletes the cilium test namespace and validates the state-- otherwise the cilium tests template is identical previous commit passed * increase timeout to 20 minutes * swap podsubnet to ubuntu 24 * register ubuntu 2404 preview feature
Reason for Change:
Adds an E2E stage for overlay and podsubnet cilium ebpf host routing enabled. Deploys relevant components and runs the standard e2e suite (wireserver, cilium connectivity, statefile validation, restarting, async delete). Should use the built versions of iptables monitor (iptables block), ip masq merger, and cns.
Begins reorganizing some of the pipeline steps and makefile targets.
Issue Fixed:
Requirements:
Notes:
green run: https://msazure.visualstudio.com/One/_build/results?buildId=139934789&view=results