fix: set logger for controller-runtime #4123
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: GitHub <[email protected]>
Collaborator
Author
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Copilot finished reviewing on behalf of
rbtr
November 17, 2025 21:11
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR injects the zap logger into controller-runtime's global logging infrastructure to ensure internal machinery logs are properly captured and formatted. The change enables controller-runtime's internal operations to use the application's configured zap logger instead of the default logger.
- Adds the controller-runtime log package import
- Sets the global controller-runtime logger to use the application's zap logger via zapr adapter
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
behzad-mir
approved these changes
Nov 17, 2025
nddq
approved these changes
Nov 19, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
injects the zap logger into controller-runtime so that internal machinery logs work