-
Notifications
You must be signed in to change notification settings - Fork 260
add AKS Swiftv2 Manifold E2E in ACN pipeline #4128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| # AKS Swiftv2 Singularity E2E tests | ||
| - template: multitenancy/swiftv2-singularity-e2e.stages.yaml | ||
| parameters: | ||
| dependsOn: manifests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be added to ACN PR pipeline.yaml as well or it will get missed before a Tag is created... We do not want to create multiple tags because of a CI/CD miss.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We currently don't have the hardware to support multiple runs as ACN PR pipeline is used.
ac53d7a to
4c05682
Compare
0280e70 to
a452830
Compare
| templateParameters: 'useAcnPublic: true, cnscniversion: $(TAG), cnscniversionwindows: $(TAG), cnscniImagePrefix: $(IMAGE_REPO_PATH)/' | ||
| useSameBranch: false | ||
| queueBuildForUserThatTriggeredBuild: true | ||
| branchToUse: 'refs/heads/sharifna/runner/release-gate' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to change this to master branch once Runners pipeline changes are merged.
64db33a to
ce3da3d
Compare
ce3da3d to
4b8616c
Compare
| ${{ if eq(parameters.dependsOn, 'publish') }}: | ||
| IMAGE_REPO_PATH_REF: 'azure-' | ||
| ${{ else }}: | ||
| IMAGE_REPO_PATH_REF: $(IMAGE_REPO_PATH) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain the flow on how this works?
Reason for Change:
This PR adds AKS Swiftv2 Manifold E2E tests to the ACN pipeline to ensure that newer CNS/CNI versions pass these scenarios testing (BYON Accelnet and IB on Windows and Linux) before being released.
Issue Fixed:
Requirements:
Notes: