Better error message when nics aren't programmed #4145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves error messaging when Network Containers (NCs) aren't programmed on a host by providing clearer diagnostic information to help troubleshoot issues. The changes add informational logging and enhance error messages with more specific details about which NCs are outdated and which have been successfully programmed.
Key Changes
- Added informational log message when no NCs have been programmed yet, indicating CNI conflist generation is skipped
- Enhanced error message to show both outdated NCs and currently programmed NICs from NMA/IMDS for better debugging
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
| // need to return an error indicating that | ||
| if len(outdatedNCs) > 0 { | ||
| return len(programmedNCs), errors.Errorf("unable to update some NCs: %v, missing or bad response from NMA or IMDS", outdatedNCs) | ||
| return len(programmedNCs), errors.Errorf("Have outdated NCs: %v, Current Programmed nics from NMA/IMDS %v", outdatedNCs, programmedNCs) |
There was a problem hiding this comment.
The error message has grammar and capitalization issues:
- "Have" should be lowercase "have" (error messages typically start with lowercase)
- "nics" should be "NICs" (consistent with "NCs" used elsewhere)
- "Current Programmed" should be "currently programmed" (grammatically correct)
- Missing colon before the second %v placeholder
Suggested fix:
return len(programmedNCs), errors.Errorf("have outdated NCs: %v, currently programmed NICs from NMA/IMDS: %v", outdatedNCs, programmedNCs)
Suggested change
| return len(programmedNCs), errors.Errorf("Have outdated NCs: %v, Current Programmed nics from NMA/IMDS %v", outdatedNCs, programmedNCs) | |
| return len(programmedNCs), errors.Errorf("have outdated NCs: %v, currently programmed NICs from NMA/IMDS: %v", outdatedNCs, programmedNCs) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Issue Fixed:
Requirements:
Notes: