ci: Convert unit tests from Azure Pipelines to GitHub Actions by Copilot · Pull Request #4298 · Azure/azure-container-networking

Copilot · 2026-03-27T18:01:02Z

This pull request introduces a new GitHub Actions workflow for running unit tests and collecting code coverage across Linux and Windows environments. Additionally, it improves the reliability of IPv6 network container test assertions by making them independent of response order.

CI/CD Improvements:

Added a comprehensive .github/workflows/unit-tests.yml GitHub Actions workflow that automates setup, testing, and code coverage reporting for both Linux (Ubuntu 22.04, 24.04) and Windows, including multi-module coverage aggregation and artifact uploads.

Test Reliability Enhancements:

Updated TestPostNetworkContainersWithIPv6 in cns/restserver/api_test.go to verify IPv6 configurations by network container ID rather than relying on response order, making the test more robust and less prone to false negatives due to ordering differences.

Agent-Logs-Url: https://github.com/Azure/azure-container-networking/sessions/65c859ae-cffd-4891-a71d-15c17aa8a992 Co-authored-by: jpayne3506 <89417863+jpayne3506@users.noreply.github.com>

jpayne3506 · 2026-03-27T20:00:31Z

@copilot explain to me other options for irongut/CodeCoverageSummary usage and why you chose it.

Copilot · 2026-03-27T20:02:56Z

@copilot explain to me other options for irongut/CodeCoverageSummary usage and why you chose it.

The main alternatives for publishing Cobertura XML coverage in GitHub Actions are:

irongut/CodeCoverageSummary@v1.3.0 (chosen) — Reads Cobertura XML directly and posts a formatted markdown table to the job summary and/or as a PR comment. No external service needed. Purpose-built for this format, which is exactly what gocov-xml produces. The issue brief also listed it as a first-choice replacement for PublishCodeCoverageResults@1.
5monkeys/cobertura-action — Similar scope (Cobertura → PR comment), but also annotates changed lines with coverage diff. Slightly heavier and less commonly maintained.
codecov/codecov-action / coverallsapp/github-action — Upload coverage to Codecov.io or Coveralls.io (third-party SaaS). More powerful dashboards and trend tracking, but require external accounts, tokens, and introduce a dependency on an outside service the repo doesn't currently use.
actions/upload-artifact only — Just archives the XML file; no automated summary or PR comment. Useful as a fallback but provides no visibility without manual download.
dorny/test-reporter — Focused on test result reporting (JUnit XML) rather than code coverage; doesn't natively render Cobertura coverage summaries.

I picked irongut/CodeCoverageSummary because it is the closest self-contained equivalent to the AZP PublishCodeCoverageResults@1 task: it consumes Cobertura XML, requires no external service, and surfaces results directly in the PR/job summary — matching the original pipeline's intent with minimal added complexity.

Copilot

Pull request overview

This PR migrates the unit test pipeline from Azure Pipelines (.pipelines/templates/run-unit-tests.yaml) to a native GitHub Actions workflow, keeping the existing Linux test execution/coverage generation behavior and adding a coverage summary publishing step.

Changes:

Adds a new GitHub Actions workflow to run unit tests on Linux and Windows.
Produces and uploads per-OS coverage artifacts, and generates a Cobertura XML report from Linux coverage.
Publishes a markdown coverage summary via irongut/CodeCoverageSummary@v1.3.0.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

.github/workflows/unit-tests.yml

…ode propagation Agent-Logs-Url: https://github.com/Azure/azure-container-networking/sessions/22d6fdb8-35a0-4791-a1bc-8ea11a3b1464 Co-authored-by: jpayne3506 <89417863+jpayne3506@users.noreply.github.com>

jpayne3506 · 2026-03-28T02:44:55Z

cns/restserver/api_test.go

-	// Verify each NC has IPv6Configuration
-	for i, nc := range ncResponses.NetworkContainers {
-		assert.Equal(t, ncParamsWithIPv6[i].ipv6Config.IPSubnet.IPAddress, nc.IPv6Configuration.IPSubnet.IPAddress, "NC %d: IPv6 address mismatch", i)
-		assert.Equal(t, ncParamsWithIPv6[i].ipv6Config.GatewayIPAddress, nc.IPv6Configuration.GatewayIPAddress, "NC %d: IPv6 gateway mismatch", i)
+	// Verify each NC has IPv6Configuration (index by NC ID to avoid ordering assumptions)
+	ncByID := make(map[string]cns.GetNetworkContainerResponse, len(ncResponses.NetworkContainers))
+	for _, nc := range ncResponses.NetworkContainers {
+		ncByID[nc.NetworkContainerID] = nc
+	}
+	for i, params := range ncParamsWithIPv6 {
+		ncID := "Swift_" + params.ncID
+		nc, ok := ncByID[ncID]
+		require.True(t, ok, "NC %d (%s) not found in response", i, ncID)
+		assert.Equal(t, params.ipv6Config.IPSubnet.IPAddress, nc.IPv6Configuration.IPSubnet.IPAddress, "NC %d: IPv6 address mismatch", i)
+		assert.Equal(t, params.ipv6Config.GatewayIPAddress, nc.IPv6Configuration.GatewayIPAddress, "NC %d: IPv6 gateway mismatch", i)


Fix captures iterating through map with hard coded assertions. Maps do not have a deterministic ordering.

jpayne3506 · 2026-03-28T02:53:16Z

After this runs for a little bit, I am in favor of removing UTs from AZP. This workflow would make them redundant.

Hope is this takes 15-25 minutes off from the AZP PR pipeline.

jpayne3506 · 2026-03-28T02:53:25Z

/azp run Azure Container Networking PR

azure-pipelines · 2026-03-28T02:53:36Z

Azure Pipelines successfully started running 1 pipeline(s).

QxBytes · 2026-03-30T23:12:19Z

.github/workflows/unit-tests.yml

+          GOOS=linux gocov convert linux-coverage.out > linux-coverage.json
+          GOOS=linux gocov-xml < linux-coverage.json > linux-coverage.xml
+
+          # TODO: Add windows coverage back in once PublishCodeCoverageResults v2 works with BuildQualityChecks


If there's no equivalent for gh actions we can probably remove this (and the comment at the end). Also seems like irongut also has an option to fail below a threshold (I think it only checks total coverage?) but we can look into that later.

Initial plan

7aae3f7

Copilot AI assigned Copilot and jpayne3506 Mar 27, 2026

Copilot started work on behalf of jpayne3506 March 27, 2026 18:01 View session

Copilot AI linked an issue Mar 27, 2026 that may be closed by this pull request

Convert UTs from AZP to GH Workflow #4297

Open

Add GitHub Actions workflow for unit tests (convert from AZP)

b265b8e

Agent-Logs-Url: https://github.com/Azure/azure-container-networking/sessions/65c859ae-cffd-4891-a71d-15c17aa8a992 Co-authored-by: jpayne3506 <89417863+jpayne3506@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Convert Azure Pipelines YAML to GitHub Actions workflow~~ Convert unit tests from Azure Pipelines to GitHub Actions Mar 27, 2026

Copilot AI requested a review from jpayne3506 March 27, 2026 18:08

Copilot finished work on behalf of jpayne3506 March 27, 2026 18:08

jpayne3506 requested a review from Copilot March 27, 2026 19:59

Copilot started work on behalf of jpayne3506 March 27, 2026 20:00 View session

chore: manual updates for go version + security

db6fa9e

Copilot started reviewing on behalf of jpayne3506 March 27, 2026 20:02 View session

Copilot finished work on behalf of jpayne3506 March 27, 2026 20:04

Copilot AI reviewed Mar 27, 2026

View reviewed changes

.github/workflows/unit-tests.yml Show resolved Hide resolved

.github/workflows/unit-tests.yml Show resolved Hide resolved

.github/workflows/unit-tests.yml Show resolved Hide resolved

.github/workflows/unit-tests.yml Show resolved Hide resolved

Copilot started work on behalf of jpayne3506 March 27, 2026 20:41 View session

wrap fd-redirect/tee block with set +e/+o pipefail to preserve exit-c…

d15b394

…ode propagation Agent-Logs-Url: https://github.com/Azure/azure-container-networking/sessions/22d6fdb8-35a0-4791-a1bc-8ea11a3b1464 Co-authored-by: jpayne3506 <89417863+jpayne3506@users.noreply.github.com>

Copilot finished work on behalf of jpayne3506 March 27, 2026 20:46

jpayne3506 added 4 commits March 27, 2026 17:39

test: linux runner

969cf2e

test: use window cmd shell

b6657ab

test: 22.04

13a7e7d

ci: add required npm pkgs

f5362d7

jpayne3506 added ci Infra or tooling. needs-backport Change needs to be backported to previous release trains release/1.5 Change affects v1.5 release train release/1.6 Change affects 1.6 release train release/1.7 Change affects v1.7 release train labels Mar 28, 2026

jpayne3506 changed the title ~~Convert unit tests from Azure Pipelines to GitHub Actions~~ ci: Convert unit tests from Azure Pipelines to GitHub Actions Mar 28, 2026

fix: CNS UT ordering issue

8af8916

jpayne3506 requested review from QxBytes, rayaisaiah and rbtr March 28, 2026 02:32

ci: add merge group and concurrency group

28983ad

jpayne3506 reviewed Mar 28, 2026

View reviewed changes

jpayne3506 requested a review from estebancams March 28, 2026 02:48

jpayne3506 marked this pull request as ready for review March 28, 2026 02:50

jpayne3506 requested review from a team as code owners March 28, 2026 02:50

jpayne3506 enabled auto-merge March 28, 2026 03:01

QxBytes reviewed Mar 30, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci: Convert unit tests from Azure Pipelines to GitHub Actions#4298

ci: Convert unit tests from Azure Pipelines to GitHub Actions#4298
Copilot wants to merge 10 commits intomasterfrom
copilot/convert-azp-to-gh-workflow

Copilot AI commented Mar 27, 2026 •

edited by jpayne3506

Loading

Uh oh!

jpayne3506 commented Mar 27, 2026

Uh oh!

Copilot AI commented Mar 27, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jpayne3506 Mar 28, 2026 •

edited

Loading

Uh oh!

jpayne3506 commented Mar 28, 2026

Uh oh!

jpayne3506 commented Mar 28, 2026

Uh oh!

azure-pipelines bot commented Mar 28, 2026

Uh oh!

QxBytes Mar 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Copilot AI commented Mar 27, 2026 • edited by jpayne3506 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jpayne3506 commented Mar 27, 2026

Uh oh!

Copilot AI commented Mar 27, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jpayne3506 Mar 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jpayne3506 commented Mar 28, 2026

Uh oh!

jpayne3506 commented Mar 28, 2026

Uh oh!

azure-pipelines bot commented Mar 28, 2026

Uh oh!

QxBytes Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Mar 27, 2026 •

edited by jpayne3506

Loading

jpayne3506 Mar 28, 2026 •

edited

Loading